Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Commit

Permalink
Add unnecessary copy check to clang-tidy
Browse files Browse the repository at this point in the history
  • Loading branch information
KellenSunderland committed Aug 25, 2018
1 parent 089f47b commit 46c9d6b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Checks: >

# In order to trigger an error, you must have a rule defined both in checks and in this section.
WarningsAsErrors: >
cppcoreguidelines-no-malloc
cppcoreguidelines-no-malloc, performance-unnecessary-copy-initialization
# Todo: define a better regex match that includes most project headers, but excludes third party
# code.
Expand Down
2 changes: 1 addition & 1 deletion src/operator/contrib/roi_align.cc
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ void ROIAlignForwardCompute(const nnvm::NodeAttrs& attrs,
CHECK_EQ(out_data.size(), expected_out);
CHECK_EQ(out_data[roialign::kOut].shape_[0], in_data[roialign::kBox].shape_[0]);

const ROIAlignParam param& = nnvm::get<ROIAlignParam>(attrs.parsed);
const ROIAlignParam& param = nnvm::get<ROIAlignParam>(attrs.parsed);

const int count = out_data[roialign::kOut].Size();
// const int num_rois = in_data[roialign::kBox].size(0);
Expand Down

0 comments on commit 46c9d6b

Please sign in to comment.