Minor algorithm changes #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tomaswolf
commented
Sep 5, 2024
tomaswolf
commented
- strnup761x25519-sha512 is now an official IANA name
- fix key size of ChaCha20-Poly1305 cipher
It got assigned a IANA "codepoint".[1] The former "@openssh.com" name is now a legacy name. [1] https://www.iana.org/assignments/ssh-parameters/ssh-parameters.xhtml#ssh-parameters-16
64 bytes is 512 bits, not 256. Also remove the "kdfSize" parameter from the constructor. It's pointless and just a source of hard to spot consistency errors if one has to give the key size twice, first in bytes, then in bits. Just give the key size in bits, and compute the number of bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.