[MNG-7347] SessionScoped beans should be singletons for a given session #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested changes
Dec 22, 2021
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/lifecycle/internal/ReactorContext.java
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/session/scope/internal/SessionScope.java
Show resolved
Hide resolved
cstamas
approved these changes
Jan 6, 2022
michael-o
requested changes
Jan 7, 2022
Let me provide a PR for 3.8.5. |
michael-o
approved these changes
Jan 7, 2022
|
Running ITs... |
|
Passes for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
The original scopes were working correctly but did not support multithreaded builds.
The new scope implementation does not use threading at all, so it's safer in a multithreaded build.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.