[MNG-6776] Inconsistent list of parameters for MojoDescriptor (testcase) #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slachiewicz
force-pushed
the
MNG-6776-tc
branch
from
20b87d3
to
7e6a305
Compare
slachiewicz
force-pushed
the
MNG-6776-tc
branch
from
7e6a305
to
54abc10
Compare
slachiewicz
force-pushed
the
MNG-6776-tc
branch
from
54abc10
to
95bd6f3
Compare
slachiewicz
force-pushed
the
MNG-6776-tc
branch
from
95bd6f3
to
8e399f8
Compare
|
Yup, this is wrong, but: these classes are NOT used/mutated at runtime, but are populated from sources (buildtime) and populated from XML (runtime). Still, this leaves a room for improvement. IMO, you can pick up #584 and this UT and create a PR. |
|
@slachiewicz could you please push the UT to this PR #584 ? |
|
Superseded by #584 |
pzygielo
pushed a commit
to pzygielo/maven
that referenced
this pull request
Jan 4, 2023
If the scope/optional for a dependency with an entry in dependency management is explicitly defined in a profile dependency but not in the dependency management section, then use the scope/optional defined in the profile dependency rather than falling back to the default value
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.