-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[RSPEC-S1068] Remove unused private fields
#2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,17 +35,6 @@ | |
| * | ||
| */ | ||
| public final class CLIReportingUtils { | ||
| // CHECKSTYLE_OFF: MagicNumber | ||
| public static final long MB = 1024 * 1024; | ||
|
|
||
| private static final long ONE_SECOND = 1000L; | ||
|
|
||
| private static final long ONE_MINUTE = 60 * ONE_SECOND; | ||
|
|
||
| private static final long ONE_HOUR = 60 * ONE_MINUTE; | ||
|
|
||
| private static final long ONE_DAY = 24 * ONE_HOUR; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this might be API but seems unused
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Want to investigate, what its actually used for. |
||
| // CHECKSTYLE_ON: MagicNumber | ||
|
|
||
| public static final String BUILD_VERSION_PROPERTY = "version"; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,10 +28,6 @@ | |
|
|
||
| class MavenITmng6401ProxyPortInterpolationTest extends AbstractMavenIntegrationTestCase { | ||
|
|
||
| private Proxy proxy; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These might be used in a weird way by reflection in the integration tests. I'm not sure in this case, but Maven does have a lot of private things that look unused but really are used like that.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes then its nice to have good TC to challenge or suppress. |
||
|
|
||
| private int port; | ||
|
|
||
| protected MavenITmng6401ProxyPortInterpolationTest() { | ||
| super("(4.0.0-alpha-7,)"); | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,5 +19,4 @@ | |
| package mng; | ||
|
|
||
| public class Module5 { | ||
| private Module4 m4; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,24 +47,12 @@ | |
| */ | ||
| public class MyMojo extends AbstractMojo { | ||
|
|
||
| /** | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the comment shows why and how this is used here. Please check this sort of thing before sending PRs from automated tools.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes im sorry. order 100% test coverage or deletion.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes its unused. Details does not help me. Im unaware. From technical POV its seems obsolet. If CI happy ship or test / use as its only |
||
| * Not used, just an offset to place reactorProjects in the middle. | ||
| * @parameter default-value="${project.build.directory}" | ||
| */ | ||
| private String outputDirectory; | ||
|
|
||
| /** | ||
| * @parameter expression="${reactorProjects}" | ||
| * @required | ||
| */ | ||
| private List reactorProjects; | ||
|
|
||
| /** | ||
| * Not used, just an offset to place reactorProjects in the middle. | ||
| * @parameter default-value="${project.build.directory}" | ||
| */ | ||
| private String outputDirectory2; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems |
||
|
|
||
| public void execute() throws MojoExecutionException { | ||
| for (Iterator it = reactorProjects.iterator(); it.hasNext(); ) { | ||
| MavenProject project = (MavenProject) it.next(); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming circle issue as last block item was found.
ONE_DAY