[MNG-8527] Re-enable consumer POM, trim down the consumer pom further #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, developers, contributors, mailing lists and issue management (to discuss)
cstamas
approved these changes
Jan 23, 2025
# Conflicts: # impl/maven-core/src/test/java/org/apache/maven/internal/transformation/AbstractRepositoryTestCase.java # impl/maven-core/src/test/java/org/apache/maven/internal/transformation/impl/ConsumerPomBuilderTest.java
elharo
reviewed
Jan 25, 2025
| managedDeps.keySet().retainAll(nodes.keySet()); | ||
|
|
||
| directDeps.replaceAll((key, dep) -> { | ||
| var managedDep = managedDeps.get(key); |
There was a problem hiding this comment.
dep --> dependency here and elsewhere. In general, avoiding abbreviations in variable names and elsewhere improves readability.
|
I need to add an IT which will test dependency management pruning. |
gnodet
changed the title
gnodet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: MNG-8527
This PR aims at:
This last item was really problematic and one of the reason why it was disabled for 4.0.0.
When a project imports huge BOMs (and sometimes cascading), you could end up with tons of managed dependencies that were inlined in the consumer BOM (it has no parent and no imports).
This PR fixes the problem by making sure only the managed dependencies that can actually have an effect are kept in the consumer POM.
It also removes informational data:
I think those informations are not important on the consumer POM and are better related to build POMs.