[MNG-8461] Initial settings method must restore context state #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effective settings are (should be) created twice, once for "early boot" of Plexus when extensions are loaded up, and then again when Maven "boots". Bug was that early call "corrupted" (inited settings) in context causing that 2nd required call (due spy) was omitted. --- https://issues.apache.org/jira/browse/MNG-8461
gnodet
approved these changes
Dec 20, 2024
|
I think we can... but am now looking at MavenITmng4936EventSpyTest and it seems it does test for this thing but did not fail? |
|
So, we need to dig in, why reproducer fails, and why IT succeeds. Locally running the related IT I have this (mng-4936/target/spy.log): fixed: Apache Maven 4.0.0-rc-3-SNAPSHOT (a9f6f3b) master: Apache Maven 4.0.0-rc-3-SNAPSHOT (575ad37) Basically they are same. |
|
Still cannot figure, and I starting to doubt in our ITs... The only difference I found so far:
Still, as the code change shows, the event should not be emitted, but it seems it was? Checked also, the IT is forked, and forked executor is used, so it cannot be some "leftover state" in embedded executor... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effective settings are (should be) created twice, once for "early boot" of Plexus when extensions are loaded up, and then again when Maven "boots".
Bug was that early call "corrupted" (inited settings) in context causing that 2nd required call (due spy) was omitted. This resulted in lack of settings related spy events firing (as we do have IT for spy but it does not test settings events).
https://issues.apache.org/jira/browse/MNG-8461
Related: alextu/maven4-reproducer#1