[MNG-8395] Add a <Source> element in the model.

[desruisseaux]

JIRA issue: MNG-8395

Add a <Source> element in the model. Properties are:

• directory (inherited from FileSet)
• includes (inherited from PatternSet)
• excludes (inherited from PatternSet)
• scope
• lang
• module
• targetVersion
• targetPath (taken from <Resource>)
• filtering (taken from <Resource>)
• enabled

This commit also renames source parameter value in reader-stax.vm for avoiding name collision with the new Source model element.

[gnodet]

Error in javadoc:
https://github.com/apache/maven/actions/runs/12010924190/job/33478988107#step:11:4026

[gnodet]

Is that a Maven convention, a Java convention, or something imposed by the JVM ?

[desruisseaux]

It is a Java compiler convention. In a multi-modules project, javac automatically inserts module names at the root of class directories. For example, if a module named my.foo.module contains a foo.bar.biz.Bla class, then in single-module project (as today), javac generates the following file in the Maven target/classes/ directory:

• foo/bar/biz/Bla.class

But in a multi-modules project (would be optional and not the default), javac generates the same file at the following location instead:

• my.foo.module/foo/bar/biz/Bla.class

Other Java tools such as java understand this directory hierarchy. I.e. the --module-path can be a directory of modules, with no need to enumerate on the path each module found in the directory. I'm not sure if it is a requirement that the directory names match module names, but this is what javac does at least by default.

Above documentation of module element tries to match what javac does. It could be rephrased as "During Java compilation, we let javac do whatever it wants. For resources, we try to copy them in the same directory as javac". The current wording tries to be more specific about what happens, but the goal is to match javac and the documentation would be updated if we find mismatches.

[gnodet]

Would it make sense to reuse the new condition syntax here ?
https://maven.apache.org/ref/4-LATEST/apidocs/org/apache/maven/api/model/Activation.html#condition-syntax-heading

[desruisseaux]

I guess so. I wasn't aware of that. How should we express that?

[gnodet]

I like it a lot, this would solve a number of problems.
I think we'd need to deprecate the previous resources, sourceDirectory, scriptSourceDirectory and testSourceDirectory in the 4.x model.

[gnodet]

I wonder if we should include in next RC. @cstamas ?
Though it would require a bit more work to fix the deprecation and migration stuff. We've done a similar thing for module -> subproject.

[desruisseaux]

Another work needed is to ensure that the new <source> tag is propagated by classes such as DefaultModelPathTranslator.java. I started that work in Geomatys@5c625d3 but didn't tested it yet (I have been delayed by other work lately, but hope to be more active in March).

[cstamas]

I wonder if we should include in next RC. @cstamas ? Though it would require a bit more work to fix the deprecation and migration stuff. We've done a similar thing for module -> subproject.

I'd say go for it. We have many other things to sort out anyway. @gnodet @desruisseaux