[MNG-8302] Warn when appropriate #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootDirectory is nullable, CLIng code was not assuming this. Also, emit "no root found" warning ONLY when appropriate.
gnodet
reviewed
Oct 16, 2024
maven-cli/src/main/java/org/apache/maven/cling/invoker/Utils.java
Outdated
Show resolved
Hide resolved
|
Should we create an IT to check the various use cases ? |
gnodet
approved these changes
Oct 17, 2024
We could, but this is really minimal impact and more "user experience", nothing biggie IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First,
rootDirectoryis nullable, CLIng code was not assuming this, fixed.Second, emit the "no root found" warning ONLY when appropriate (when we have a POM in picture).
https://issues.apache.org/jira/browse/MNG-8302