-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming of ArtifactCoordinate.getVersion()
+ documentation
#1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
changed the title
getVersionConstraint + doc
Renaming of Aug 18, 2024
ArtifactCoordinate.getVersion()
+ documentation
Supersedes #1640 |
carlspring
reviewed
Aug 22, 2024
api/maven-api-core/src/main/java/org/apache/maven/api/ArtifactCoordinate.java
Outdated
Show resolved
Hide resolved
…endencyCoordinate. Rename ArtifactCoordinate.getVersion() as getVersionConstraint().
…ecated. Opportunistic addition of some missing `@Override` annotations.
# Conflicts: # api/maven-api-core/src/main/java/org/apache/maven/api/Version.java
gnodet
force-pushed
the
refactor/getVersionConstraint
branch
from
August 27, 2024 07:36
22f4881
to
92b9e45
Compare
cstamas
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coordinates
LATEST
andSNAPSHOT
from documentation since they are deprecated.@Override
annotations.DownloadedArtifact
,DownloadedDependency
andProducedArtifact