Add sanity checks

apache · Sep 7, 2024 · c5d7d81 · c5d7d81
1 parent ad88938
commit c5d7d81
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/maven-model/src/main/java/org/apache/maven/model/BaseObject.java b/maven-model/src/main/java/org/apache/maven/model/BaseObject.java
@@ -35,7 +35,7 @@ public BaseObject(Object delegate, BaseObject parent) {
     }
 
     public BaseObject(Object delegate, ChildrenTracking parent) {
-        this.delegate = delegate;
+        this.delegate = requireNonNull(delegate, "delegate cannot be null");
         this.childrenTracking = parent;
     }
 

diff --git a/...tory-metadata/src/main/java/org/apache/maven/artifact/repository/metadata/BaseObject.java b/...tory-metadata/src/main/java/org/apache/maven/artifact/repository/metadata/BaseObject.java
@@ -20,6 +20,8 @@
 
 import java.io.Serializable;
 
+import static java.util.Objects.requireNonNull;
+
 public abstract class BaseObject implements Serializable, Cloneable {
     protected transient ChildrenTracking childrenTracking;
 
@@ -28,12 +30,12 @@ public abstract class BaseObject implements Serializable, Cloneable {
     public BaseObject() {}
 
     public BaseObject(Object delegate, BaseObject parent) {
-        this.delegate = delegate;
+        this.delegate = requireNonNull(delegate, "delegate cannot be null");
         this.childrenTracking = parent != null ? parent::replace : null;
     }
 
     public BaseObject(Object delegate, ChildrenTracking parent) {
-        this.delegate = delegate;
+        this.delegate = requireNonNull(delegate, "delegate cannot be null");
         this.childrenTracking = parent;
     }
 

diff --git a/maven-settings/src/main/java/org/apache/maven/settings/BaseObject.java b/maven-settings/src/main/java/org/apache/maven/settings/BaseObject.java
@@ -20,6 +20,8 @@
 
 import java.io.Serializable;
 
+import static java.util.Objects.requireNonNull;
+
 public abstract class BaseObject implements Serializable, Cloneable {
     protected transient ChildrenTracking childrenTracking;
 
@@ -28,12 +30,12 @@ public abstract class BaseObject implements Serializable, Cloneable {
     public BaseObject() {}
 
     public BaseObject(Object delegate, BaseObject parent) {
-        this.delegate = delegate;
+        this.delegate = requireNonNull(delegate, "delegate cannot be null");
         this.childrenTracking = parent != null ? parent::replace : null;
     }
 
     public BaseObject(Object delegate, ChildrenTracking parent) {
-        this.delegate = delegate;
+        this.delegate = requireNonNull(delegate, "delegate cannot be null");
         this.childrenTracking = parent;
     }
 

diff --git a/maven-toolchain-model/src/main/java/org/apache/maven/toolchain/model/BaseObject.java b/maven-toolchain-model/src/main/java/org/apache/maven/toolchain/model/BaseObject.java
@@ -20,6 +20,8 @@
 
 import java.io.Serializable;
 
+import static java.util.Objects.requireNonNull;
+
 public abstract class BaseObject implements Serializable, Cloneable {
     protected transient ChildrenTracking childrenTracking;
 
@@ -28,12 +30,12 @@ public abstract class BaseObject implements Serializable, Cloneable {
     public BaseObject() {}
 
     public BaseObject(Object delegate, BaseObject parent) {
-        this.delegate = delegate;
+        this.delegate = requireNonNull(delegate, "delegate cannot be null");
         this.childrenTracking = parent != null ? parent::replace : null;
     }
 
     public BaseObject(Object delegate, ChildrenTracking parent) {
-        this.delegate = delegate;
+        this.delegate = requireNonNull(delegate, "delegate cannot be null");
         this.childrenTracking = parent;
     }