Fix contention on addProblem in big projects

apache · Dec 17, 2024 · 9ddd0a2 · 9ddd0a2
1 parent a68b52f
commit 9ddd0a2
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/...en-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilderResult.java b/...en-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilderResult.java
@@ -19,9 +19,9 @@
 package org.apache.maven.internal.impl.model;
 
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
-import java.util.concurrent.CopyOnWriteArrayList;
+import java.util.Queue;
+import java.util.concurrent.ConcurrentLinkedQueue;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
@@ -42,7 +42,7 @@ class DefaultModelBuilderResult implements ModelBuilderResult {
     private Model effectiveModel;
     private List<Profile> activePomProfiles;
     private List<Profile> activeExternalProfiles;
-    private final List<ModelProblem> problems = new CopyOnWriteArrayList<>();
+    private final Queue<ModelProblem> problems = new ConcurrentLinkedQueue<>();
     private final DefaultModelBuilderResult problemHolder;
 
     private final List<DefaultModelBuilderResult> children = new ArrayList<>();
@@ -125,7 +125,7 @@ public void setActiveExternalProfiles(List<Profile> activeProfiles) {
      */
     @Override
     public List<ModelProblem> getProblems() {
-        return Collections.unmodifiableList(problems);
+        return List.copyOf(problems);
     }
 
     /**