-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
- Loading branch information
Showing
5 changed files
with
173 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
102 changes: 102 additions & 0 deletions
102
its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng8245BeforePhaseCliTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.maven.it; | ||
|
|
||
| import java.io.File; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| /** | ||
| * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-8245">MNG-8245</a> | ||
| * and <a href="https://issues.apache.org/jira/browse/MNG-8246">MNG-8246</a>. | ||
| */ | ||
| class MavenITmng8245BeforePhaseCliTest extends AbstractMavenIntegrationTestCase { | ||
|
|
||
| MavenITmng8245BeforePhaseCliTest() { | ||
| super("[4.0.0-rc-2,)"); | ||
| } | ||
|
|
||
| /** | ||
| * Verify phase before:clean spits a warning and calls clean | ||
| */ | ||
| @Test | ||
| void testPhaseBeforeCleanAllWihConcurrentBuilder() throws Exception { | ||
| File testDir = extractResources("/mng-8245-before-after-phase-all"); | ||
|
|
||
| Verifier verifier = newVerifier(testDir.getAbsolutePath()); | ||
| verifier.setLogFileName("before-clean-concurrent.txt"); | ||
| verifier.addCliArguments("-b", "concurrent", "before:clean"); | ||
| verifier.execute(); | ||
|
|
||
| verifier.verifyTextInLog("Illegal call to phase 'before:clean'. The main phase 'clean' will be used instead."); | ||
| verifier.verifyTextInLog("Hallo 'before:clean' phase."); | ||
| verifier.verifyTextInLog("Hallo 'after:clean' phase."); | ||
| } | ||
|
|
||
| /** | ||
| * Verify phase before:clean spits a warning and calls clean | ||
| */ | ||
| @Test | ||
| void testPhaseBeforeCleanAllWithLegacyBuilder() throws Exception { | ||
| File testDir = extractResources("/mng-8245-before-after-phase-all"); | ||
|
|
||
| Verifier verifier = newVerifier(testDir.getAbsolutePath()); | ||
| verifier.setLogFileName("before-clean-legacy.txt"); | ||
| verifier.addCliArguments("before:clean"); | ||
| verifier.execute(); | ||
|
|
||
| verifier.verifyTextInLog("Illegal call to phase 'before:clean'. The main phase 'clean' will be used instead."); | ||
| verifier.verifyTextInLog("Hallo 'before:clean' phase."); | ||
| verifier.verifyTextInLog("Hallo 'after:clean' phase."); | ||
| } | ||
|
|
||
| /** | ||
| * Verify phase after:clean spits a warning and calls clean | ||
| */ | ||
| @Test | ||
| void testPhaseAfterCleanAllWihConcurrentBuilder() throws Exception { | ||
| File testDir = extractResources("/mng-8245-before-after-phase-all"); | ||
|
|
||
| Verifier verifier = newVerifier(testDir.getAbsolutePath()); | ||
| verifier.setLogFileName("after-clean-concurrent.txt"); | ||
| verifier.addCliArguments("-b", "concurrent", "after:clean"); | ||
| verifier.execute(); | ||
|
|
||
| verifier.verifyTextInLog("Illegal call to phase 'after:clean'. The main phase 'clean' will be used instead."); | ||
| verifier.verifyTextInLog("Hallo 'before:clean' phase."); | ||
| verifier.verifyTextInLog("Hallo 'after:clean' phase."); | ||
| } | ||
|
|
||
| /** | ||
| * Verify phase after:clean spits a warning and calls clean | ||
| */ | ||
| @Test | ||
| void testPhaseAfterCleanAllWithLegacyBuilder() throws Exception { | ||
| File testDir = extractResources("/mng-8245-before-after-phase-all"); | ||
|
|
||
| Verifier verifier = newVerifier(testDir.getAbsolutePath()); | ||
| verifier.setLogFileName("after-clean-legacy.txt"); | ||
| verifier.addCliArguments("after:clean"); | ||
| verifier.execute(); | ||
|
|
||
| verifier.verifyTextInLog("Illegal call to phase 'after:clean'. The main phase 'clean' will be used instead."); | ||
| verifier.verifyTextInLog("Hallo 'before:clean' phase."); | ||
| verifier.verifyTextInLog("Hallo 'after:clean' phase."); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
its/core-it-suite/src/test/resources/mng-8245-before-after-phase-all/pom.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" root="true" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd"> | ||
|
|
||
| <groupId>org.apahce.maven.its</groupId> | ||
| <artifactId>mng-8245</artifactId> | ||
| <version>1.0.0-SNAPSHOT</version> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>com.soebes.maven.plugins</groupId> | ||
| <artifactId>echo-maven-plugin</artifactId> | ||
| <version>0.5.0</version> | ||
| <executions> | ||
| <execution> | ||
| <id>before-clean</id> | ||
| <goals> | ||
| <goal>echo</goal> | ||
| </goals> | ||
| <phase>before:clean</phase> | ||
| <configuration> | ||
| <echos> | ||
| <echo>Hallo 'before:clean' phase.</echo> | ||
| </echos> | ||
| </configuration> | ||
| </execution> | ||
| <execution> | ||
| <id>after-clean</id> | ||
| <goals> | ||
| <goal>echo</goal> | ||
| </goals> | ||
| <phase>after:clean</phase> | ||
| <configuration> | ||
| <echos> | ||
| <echo>Hallo 'after:clean' phase.</echo> | ||
| </echos> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
|
|
||
| </build> | ||
|
|
||
| </project> |