[MSITE-1000] Introduce parser configuration parameter #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Apr 19, 2024
src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java
Show resolved
Hide resolved
michael-o
approved these changes
Apr 19, 2024
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java
Outdated
Show resolved
Hide resolved
michael-o
requested changes
Apr 19, 2024
There was a problem hiding this comment.
It does not compile for me:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project maven-site-plugin: Compilation failure: Compilation failure:
[ERROR] /var/osipovmi/Projekte/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java:[35,43] cannot find symbol
[ERROR] symbol: class ParserConfigurator
[ERROR] location: package org.apache.maven.doxia.siterenderer
[ERROR] /var/osipovmi/Projekte/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java:[48,48] cannot find symbol
[ERROR] symbol: class ParserConfigurator
[ERROR] /var/osipovmi/Projekte/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java:[40,43] cannot find symbol
[ERROR] symbol: class ParserConfigurator
[ERROR] location: package org.apache.maven.doxia.siterenderer
[ERROR] /var/osipovmi/Projekte/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java:[311,78] cannot find symbol
[ERROR] symbol: class ParserConfigurator
[ERROR] location: class org.apache.maven.plugins.site.render.AbstractSiteRenderingMojo
[ERROR] /var/osipovmi/Projekte/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/render/SiteMojo.java:[32,43] cannot find symbol
[ERROR] symbol: class ParserConfigurator
[ERROR] location: package org.apache.maven.doxia.siterenderer
[ERROR] /var/osipovmi/Projekte/maven-site-plugin/src/main/java/org/apache/maven/plugins/site/render/SiteMojo.java:[132,13] cannot find symbol
[ERROR] symbol: class ParserConfigurator
[ERROR] location: class org.apache.maven.plugins.site.render.SiteMojo
kwin
force-pushed
the
feature/configure-parser-with-plexus-configurator
branch
2 times, most recently
from
58db21e to
0c82571
Compare
|
I will happily review again after #185 has been merged. |
michael-o
requested changes
May 1, 2024
There was a problem hiding this comment.
Invoking:
D:\Entwicklung\Projekte\maven-site-plugin [feature/configure-parser-with-plexus-configurator ↓1 ↑6]> mvn clean
verify -Prun-its site -Preporting
causes
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on project maven-site-plugin: Error generating maven-plugin-report-plugin:3.10.2:report report: Illegal char <<> at index 22: apidocs/java/util/List<org/codehaus/plexus/configuration/PlexusConfiguration>.html -> [Help 1]
@slawekjaranowski WDYT?
|
It also fails with: |
|
The bug is in |
|
Here is a fix: apache/maven-plugin-tools#281 |
asfgit
force-pushed
the
feature/configure-parser-with-plexus-configurator
branch
from
0c82571 to
d5312d3
Compare
This leverages PlexusConfigurator under the hood
asfgit
force-pushed
the
feature/configure-parser-with-plexus-configurator
branch
from
d5312d3 to
edac4a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leverages PlexusConfigurator under the hood
Requires apache/maven-doxia-sitetools#140.