Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(doc) Throw more descriptive NPEx #95

Merged
merged 3 commits into from
Mar 11, 2022
Merged

(doc) Throw more descriptive NPEx #95

merged 3 commits into from
Mar 11, 2022

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Mar 4, 2022

As suggested in MJAR-286:

If this is a misconfigured pom, it should at least give a proper error message.

Thus replacing JVM-thrown NPEx with the one with message.

@pzygielo pzygielo marked this pull request as ready for review March 4, 2022 11:35
@pzygielo

This comment was marked as outdated.

Sign in to view
slawekjaranowski
slawekjaranowski reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple unit test will be appreciated 😉
it is public method

@pzygielo
(doc) UTs for in/ex-cludes with null element
cbaadf5 
This verifies/locks current behavior of throwing NPEx
on null being dereferenced in DirectoryScanner.setIncludes/Excludes.
@pzygielo
(doc) Throw more descriptive NPEx
3f56442
@pzygielo
(doc) Update UT to verify customised message
83b9e91
@pzygielo pzygielo marked this pull request as draft March 11, 2022 12:24
@pzygielo pzygielo marked this pull request as ready for review March 11, 2022 12:42
@slawekjaranowski slawekjaranowski merged commit 412b279 into apache:master Mar 11, 2022
@pzygielo pzygielo deleted the MJAR-286 branch March 11, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pzygielo @slawekjaranowski