Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-983] Drop plexus container default #87

Merged
merged 3 commits into from
May 1, 2021
Merged

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Apr 29, 2021

https://issues.apache.org/jira/browse/MSHARED-983

The complete container was only here to make use of AbstractLogEnabled
ancient class, that uses ancient logging.

Changes:

  • Drop p-c-d
  • Reorder deps by scope, test last.

The complete container was only here to make use of AbstractLogEnabled
ancient class, that uses ancient logging.

Drop it.
@cstamas cstamas self-assigned this Apr 29, 2021
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not API compatible. It deserves at least a minor version update and preferably a major version update.

@elharo elharo changed the title Drop plexus container default [MSHARED-983] Drop plexus container default Apr 29, 2021
As this change is not API compatible
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a PMC member who can create a maven-shared-utils 4.0.0 release label in Jira? or perhaps change the 3.4.0 label to 4.0.0?

@cstamas
Copy link
Member Author

cstamas commented Apr 30, 2021

Is there a PMC member who can create a maven-shared-utils 4.0.0 release label in Jira? or perhaps change the 3.4.0 label to 4.0.0?

created https://issues.apache.org/jira/projects/MSHARED/versions/12350135

@slachiewicz
Copy link
Member

Nice,with this new version we can also require java 8 (as separate ticket)

@elharo
Copy link
Contributor

elharo commented May 1, 2021

@elharo elharo merged commit 1e6748c into master May 1, 2021
@elharo elharo deleted the drop-plexus-container branch May 1, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants