Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused plexus dependency #78

Merged
merged 1 commit into from
Apr 17, 2021
Merged

remove unused plexus dependency #78

merged 1 commit into from
Apr 17, 2021

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 23, 2021

@MartinKanters
Copy link

@elharo Is there any specific reason @michael-o should look at this? IMO I would say that if the code still compiles without this dependency, we should be good in general?

@elharo
Copy link
Contributor Author

elharo commented Apr 16, 2021

Anyone can review. I try to request reviews roughly round robin amongst active committers unless I believe there's a particular reason someone might be interested in a PR.

@slachiewicz slachiewicz merged commit 5097cee into master Apr 17, 2021
@slachiewicz
Copy link
Member

Build failed:


[ERROR] /home/jenkins/workspace/en-box_maven-shared-utils_master@2/m/src/main/java/org/apache/maven/shared/utils/cli/javatool/AbstractJavaTool.java:[28,35] package org.codehaus.plexus.logging does not exist

@MartinKanters
Copy link

@slachiewicz @elharo looks like we could use GitHub Actions in this repo.. :)
Imo we should revert this PR, do you guys have any concern with that?

@pzygielo pzygielo mentioned this pull request Apr 17, 2021
@slachiewicz slachiewicz deleted the re branch April 26, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants