Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6915] Add a helper method to get the terminal width #70

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jan 21, 2021

No description provided.

pom.xml Outdated
@@ -70,7 +70,7 @@
<dependency>
<groupId>org.fusesource.jansi</groupId>
<artifactId>jansi</artifactId>
<version>2.0.1</version>
<version>2.2.0</version>
<optional>true</optional>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this marked optional instead of simply declaring it? It feels like unnecessary complexity. The model code checks for its presence but the test code doesn't seem to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be optional, it is Maven that's responsible to provide it and to decide which features are supported.
Maven 3.3.9 and earlier would otherwise have mixed output.

Copy link

@MartinKanters MartinKanters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @gnodet! Can you please rebase on master and squash your commits?

@gnodet
Copy link
Contributor Author

gnodet commented Apr 16, 2021

@MartinKanters rebased and squashed

@elharo
Copy link
Contributor

elharo commented Apr 16, 2021

@elharo elharo dismissed MartinKanters’s stale review April 16, 2021 21:15

rebased and squashed as requested

@elharo elharo merged commit b4577c9 into apache:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants