Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHARED-951] fix exception handling #61

Merged
merged 2 commits into from
Aug 14, 2020
Merged

[MSHARED-951] fix exception handling #61

merged 2 commits into from
Aug 14, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Aug 13, 2020

@elharo elharo changed the title fix exception handling [MSHARED-951] fix exception handling Aug 13, 2020
pzygielo
pzygielo reviewed Aug 13, 2020
View reviewed changes
src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomBuilder.java Outdated
@@ -84,14 +84,14 @@ public static Xpp3Dom build( @WillClose InputStream is, @Nonnull String encoding
}
catch ( UnsupportedEncodingException e )
{
throw new RuntimeException( e );
throw new XmlPullParserException( e );
}
}

/**
* @param reader {@link Reader}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such parameter reader, as in #58 it was renamed to in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@elharo elharo merged commit 1a015f1 into master Aug 14, 2020
@elharo elharo deleted the ex branch August 14, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzygielo pzygielo pzygielo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elharo @pzygielo