Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHARED-898] prefer JDK classes to DirectoryScanner #45

Merged
merged 2 commits into from
May 29, 2020
Merged

[MSHARED-898] prefer JDK classes to DirectoryScanner #45

merged 2 commits into from
May 29, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 29, 2020

@elharo
-a
4a6b1f7 
deprecate much DirectoryScanner code in favor of java.nio.file.DirectoryStream and related classes available in Java 7 and later
@elharo
suppress deprecation warnings in test file
8a83d0d
@elharo elharo merged commit 0760867 into master May 29, 2020
@elharo elharo deleted the gen branch May 29, 2020 21:46
@olamy
Copy link
Member

olamy commented May 29, 2020

I wonder if it's faster? (jmh tests?)

@tisonkun
Copy link
Member

tisonkun commented Jan 4, 2023

@elharo do we have a migration example? It seems that DirectoryScanner is still far more fruitful then bare java.nio.file.DirectoryStream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elharo @olamy @tisonkun @michael-o