[MSHARED-861] remove unreachable package #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires a JIRA issue first. |
|
Did you actually try the tests on Java 11+? Did they fail? |
elharo
commented
Mar 8, 2020
There was a problem hiding this comment.
The existing tests would not fail on Java 11+. However since these classes are non-public the only way to use them would be to use reflection to cast away the access control, or to add classes directly to these packages. Neither is likely, and both should fail in Java 11.
elharo
changed the title
michael-o
approved these changes
Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michael-o None of the model classes in the reflection package are public. Thus unless someone is doing some really skanky reflection hacks that won't work in java 9+, this is completely unused. My best guess is that someone meant to do something with this, but abandoned it before making it public.