[SCM-977] Support for retrieving tags from the changelog #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsbasjes
force-pushed
the
SCM-977-ChangelogTags
branch
from
81e1480
to
192a300
Compare
|
I have implemented the tags retrieval for gitexe, jgit and hg. |
|
@nielsbasjes I will take a look at all of your PRs next month. This month, very unlikely. |
michael-o
requested changes
May 19, 2022
michael-o
requested changes
May 19, 2022
...ava/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumerTest.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumerTest.java
Outdated
Show resolved
Hide resolved
nielsbasjes
force-pushed
the
SCM-977-ChangelogTags
branch
2 times, most recently
from
a52f1a6
to
4c64430
Compare
nielsbasjes
force-pushed
the
SCM-977-ChangelogTags
branch
from
4c64430
to
d55a48a
Compare
michael-o
requested changes
May 25, 2022
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/maven/scm/provider/hg/command/changelog/HgChangeLogCommandTckTest.java
Outdated
Show resolved
Hide resolved
michael-o
reviewed
May 25, 2022
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java
Outdated
Show resolved
Hide resolved
michael-o
requested changes
May 25, 2022
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java
Outdated
Show resolved
Hide resolved
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java
Outdated
Show resolved
Hide resolved
nielsbasjes
force-pushed
the
SCM-977-ChangelogTags
branch
2 times, most recently
from
3edaa52
to
60dec10
Compare
michael-o
requested changes
May 25, 2022
...ava/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumerTest.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumerTest.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumerTest.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumerTest.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumerTest.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumerTest.java
Outdated
Show resolved
Hide resolved
...m-test/src/main/java/org/apache/maven/scm/tck/command/changelog/ChangeLogCommandTckTest.java
Outdated
Show resolved
Hide resolved
|
So as far as I understand your implementation, it side walks with "git log" and reads out whether those commits belong to tags as well?! |
michael-o
force-pushed
the
SCM-977-ChangelogTags
branch
from
60dec10
to
b0f1c79
Compare
michael-o
pushed a commit
to nielsbasjes/maven-scm
that referenced
this pull request
May 26, 2022
michael-o
force-pushed
the
SCM-977-ChangelogTags
branch
from
b0f1c79
to
3e93ebe
Compare
|
Added those tiny changes myself. Requires #149 to be merged first. |
michael-o
approved these changes
May 26, 2022
michael-o
force-pushed
the
SCM-977-ChangelogTags
branch
from
3e93ebe
to
b04525f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue SCM-977
My aim is to support having something like https://www.conventionalcommits.org/ in the maven-release-plugin.
This simply means that the next version of a release is calculated from the last tag in the version history and the patterns in the commit messages since that tag.
To support this idea the maven-scm should be extended to also retrieve the tags with the changelog command on SCM implementations that support this idea.
This patch adds