Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM-948 - Make limit parameter work for svnexe and gitexe changelog goal #119

Closed
wants to merge 1 commit into from

Conversation

cquoss
Copy link
Contributor

@cquoss cquoss commented Jul 23, 2021

No description provided.

@cquoss cquoss changed the title Make limit parameter work for svnexe and gitexe changelog goal SCM-948 - Make limit parameter work for svnexe and gitexe changelog goal Jul 23, 2021
@eolivelli
Copy link

Can you please explain more your patch?

@cquoss
Copy link
Contributor Author

cquoss commented Jul 25, 2021

Happily. The old PR was better documented but got erased after resetting hard to upstream master and force pushing.
At our company we use a customized version of maven-release that talks in some added phases with our jira.
To be more precise we extract in one phase the current jira issue related with this maven project from the latest scm commit comment.
To not have the scm provider always drill down through the complete log history i also customized maven-scm in our nexus repository to only return the latest log entry by making the limit parameter functional for the changelog goal for the two providers we are interested in (gitexe and svnexe).
My patch here may not be perfect but with all the abstraction and the already deprecated methods i made two attempts in the past (the first inventing new methods and instantly deprecating them, the second removing all deprecation from the code and directly go through request -> parameters to command line creation).
Both have been rejected so now this is my third attempt doing this by overriding the executeCommand method for these two providers mentioned.

@cquoss
Copy link
Contributor Author

cquoss commented Jul 25, 2021

Another thing: Travis CI builds for jdk 7 and 8 have errors. To me it looks like jdk 7 and 8 are not available. Is some on it to fix the config on this?

@@ -148,9 +169,21 @@ protected ChangeLogScmResult executeChangeLogCommand( ScmProviderRepository repo
// ----------------------------------------------------------------------

/**
* this constructs creates the commandline for the git-whatchanged command.
* <p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This <p> isn't necessary.

@michael-o
Copy link
Member

Note: The order how those options are processed differ between Subversion and Git. This is bad for consistency, but not your fault I do not expect you to fix that. The change looks fine to me.

@michael-o michael-o self-requested a review August 5, 2021 18:59
@asfgit asfgit closed this in 4cafe0f Aug 5, 2021
@cquoss cquoss deleted the SCM-948 branch June 29, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants