[SCM-947] #109
[SCM-947] #109
Conversation
# Conflicts: # maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java # maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java
|
Something in Travis CI seems broken, unrelated to my changes. For builds with Java 6 and 7 the config does not seem to fit any more. |
|
Another point: Where lies the documentation for the changelog goal of the maven-scm-plugin? An update here should be part of / done in parallel by me / for this pull request. |
maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/ChangeLogMojo.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| if ( StringUtils.isNotEmpty( startScmVersion ) ) |
There was a problem hiding this comment.
Hmm. I believe i did some sort of alphabetical ordering.
There was a problem hiding this comment.
Should this be moved to somewhere else?
|
Does this require SCM-948 first? |
|
TBH: I do not know any more. Let us do this: first merge this PR because this should introduce log request all the way down to the command line calls of svn and git. And then SCM-948 should be easy-peasy simply enabling the limit param on top of this. |
|
I have starred this and will pick up tomorrow. |
|
OK. I have been too optimistic. But at least having this will help test SCM-948 since the mojo then sends down a changelog request. But it still uses the deprecated methods with single parms instead of the changelog request. This needs to be changed with SCM-948. But SCM-947 could be merged from my point of view. -Dlimit=1 on changelog goal shows no effect as one can easily verify. But that is up to SCM-948 to fix. And documentation of Changelog Goal of Mojo needs update. Where does that reside? |
|
I have merge SCM-948, am I good to review this now? |
|
Yes. You are. |
Pull request for SCM-947.
Make all parameter of changelog request available in changelog mojo.