[MRELEASE-985] Override snapshot dependencies from command line #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfscholte
reviewed
May 6, 2019
...nager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java
Outdated
Show resolved
Hide resolved
rfscholte
reviewed
May 7, 2019
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
Outdated
Show resolved
Hide resolved
ptahchiev
force-pushed
the
MRELEASE-985-new
branch
2 times, most recently
from
c745790
to
5c80a60
Compare
rfscholte
reviewed
May 8, 2019
maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
Outdated
Show resolved
Hide resolved
rfscholte
reviewed
May 8, 2019
...nager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java
Outdated
Show resolved
Hide resolved
- Copy properties to the correct release descriptor in DefaultReleaseManager. - Do not fail the build if the property is resolved from the comand-line (in CheckDependencySnapshotsPhase). See https://issues.apache.org/jira/browse/MRELEASE-985
ptahchiev
force-pushed
the
MRELEASE-985-new
branch
from
5c80a60
to
8659bb9
Compare
|
I've pushed the branch to see how Jenkins is doing. When is is good, I'll merge it. While working on this issue I noticed that one on the main features is broken due to the refactoring: it doesn't detect snapshots anymore. Will write an integration test for it to ensure this won't happen again. |
olamy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/MRELEASE-985