Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRELEASE-1154] Never fail for unresolvable version expressions #230

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MRELEASE-1154] Never fail for unresolvable version expressions #230

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4aedda
[MRELEASE-1154] Improve exception message for unresolvable version
kwin Aug 27, 2024
9de05da
Never fail for locally unresolvable version expressions
kwin Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,16 +616,17 @@ private void rewriteArtifactVersions(
+ rawVersion);
} else {
// the expression used to define the version of this artifact may be inherited
// TODO needs a better error message, what pom? what dependency?
throw new ReleaseFailureException(
"Could not find property resolving version expression: " + rawVersion);
"Could not find property resolving version expression: " + rawVersion
+ " for artifact " + key + " in the project " + projectId
+ ".");
}
}
} else {
// the expression used to define the version of this artifact may be inherited
// TODO needs a better error message, what pom? what dependency?
throw new ReleaseFailureException(
"Could not find properties resolving version expression : " + rawVersion);
"Could not find properties resolving version expression : " + rawVersion
michael-o marked this conversation as resolved.
Show resolved Hide resolved
+ " for artifact " + key + " in the project " + projectId + ".");
}
} else {
// different/previous version not related to current release
Expand Down