[MRELEASE-1109] Support CI friendly versions #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Aug 17, 2023
...se-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java
Show resolved
Hide resolved
olamy
approved these changes
Aug 20, 2023
mkolesnikov
reviewed
Nov 29, 2023
| AbstractRewritePomsPhase.extractPropertyFromExpression(versionElement.getTextNormalize()); | ||
| Properties properties = getProperties(); | ||
| if (properties != null) { | ||
| properties.computeIfPresent(ciFriendlyPropertyName, (k, v) -> version); |
There was a problem hiding this comment.
Unimplemented (stub) method call, it does nothing.
mkolesnikov
reviewed
Nov 29, 2023
| * Regular expression pattern matching Maven expressions (i.e. references to Maven properties). | ||
| * The first group selects the property name the expression refers to. | ||
| */ | ||
| private static final Pattern EXPRESSION_PATTERN = Pattern.compile("\\$\\{(.+)\\}"); |
There was a problem hiding this comment.
Would fail in case of <version>${revision}${sha1}${changelist}</version>, looks like the revision the only property from CI Friendly is supported right now.
|
After all, this isn't fine anymore. This has introduced anothe regression: https://issues.apache.org/jira/browse/MRELEASE-1154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.