Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRELEASE-1123] Fix for Maven 4 compatibility #186

Merged
merged 1 commit into from
May 26, 2023

Conversation

slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented May 14, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MRELEASE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MRELEASE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski slawekjaranowski marked this pull request as draft May 14, 2023 11:19
@slawekjaranowski slawekjaranowski force-pushed the MRELEASE-1123-build-mvn4 branch 2 times, most recently from e9c80be to ca5b587 Compare May 15, 2023 18:39
@slawekjaranowski slawekjaranowski changed the title Try build with Maven 4 [MRELEASE-1123] Fix for Maven 4 May 18, 2023
@michael-o
Copy link
Member

@nielsbasjes, can you verify this on your end as well?

@nielsbasjes
Copy link
Contributor

@nielsbasjes, can you verify this on your end as well?

I installed Apache Maven 4.0.0-alpha-5.
I installed this branch of the maven-release plugin locally (using maven 4).
I then updated the dependency of maven-release-plugin in my project https://github.com/nielsbasjes/conventional-commits-maven-release and ran all the tests and integration tests.

All of this worked fine for me (except for my project having a few minor things that are not maven 4 compatible).

So from my end this all looks good.

@michael-o
Copy link
Member

@nielsbasjes, can you verify this on your end as well?

I installed Apache Maven 4.0.0-alpha-5. I installed this branch of the maven-release plugin locally (using maven 4). I then updated the dependency of maven-release-plugin in my project https://github.com/nielsbasjes/conventional-commits-maven-release and ran all the tests and integration tests.

All of this worked fine for me (except for my project having a few minor things that are not maven 4 compatible).

So from my end this all looks good.

Thanks, this is good news!

@slawekjaranowski
Copy link
Member Author

@nielsbasjes thanks for testing.

I will remove a build by Maven 4.x - and prepare for merge.

@slawekjaranowski slawekjaranowski changed the title [MRELEASE-1123] Fix for Maven 4 [MRELEASE-1123] Fix for Maven 4 compatibility May 23, 2023
@slawekjaranowski slawekjaranowski marked this pull request as ready for review May 23, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants