improve dependency declarations #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Mar 16, 2023
maven-release-manager/pom.xml
Outdated
| <artifactId>sisu-guice</artifactId> | ||
| <version>3.2.3</version> | ||
| <classifier>no_aop</classifier> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
Really this or the Guice from Google. This is a fork, no? @cstamas
There was a problem hiding this comment.
I left this one out since the actual dep is in provided scope and it does not matter at runtime.
|
I just copied what dependency analyzer claimed we were already using. If it should be a different one, then we definitely need to declare it. (or maybe this is a bug in dependency analyzer and it's not correctly analyzing?) |
|
I will try to review this after SCM release |
This closes #176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More accurately declare the dependencies of this plugins. This removes some — not all — of the dependency analyzer warnings in the build. Some of the warnings are false positives and perhaps require improvements to the dependency analyzer.