Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRELEASE-1115] Upgrade Parent to 39 #172

Merged
merged 1 commit into from
Mar 12, 2023
Merged

[MRELEASE-1115] Upgrade Parent to 39 #172

merged 1 commit into from
Mar 12, 2023

Conversation

michael-o
Copy link
Member

This closes #105

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MRELEASE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MRELEASE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@nielsbasjes
Copy link
Contributor

Big change!
Looks like this changes the coding standard?

@michael-o
Copy link
Member Author

Big change! Looks like this changes the coding standard?

Correct, we have internally agreed to use a newer formatting standard to get rid of those old-style formattings. I will merge in a few minutes since all checks have passed.

@asfgit asfgit merged commit f2f3943 into master Mar 12, 2023
@michael-o michael-o deleted the MRELEASE-1115 branch March 12, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants