Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRELEASE-839]: Unable to supply tag to release for release:perform #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edwardUL99
Copy link

@edwardUL99 edwardUL99 commented Sep 10, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

This PR introduces a fix which allows a tag to be supplied either using a -Dtag=<tag> flag or passing the tag into the <configuration><tag>tag</tag></configuration> section of the release plugin in the pom. The PerformReleasePojo previously incorrectly extended AbstractReleaseMojo where it now extends AbstractScmReleaseMojo. This required some small changes to the unit tests where I updated the stub files to correct a NPE error and to also assert that the ScmReleaseLabel was being populated correctly. I also added a directory MRELEASE-839 under it/projects/perform which contains the integration test for this issue.

From the Jira, the command to get the fixed changes is:

mvn org.apache.maven.plugins:maven-release-plugin:3.0.0-M7-SNAPSHOT:perform -DconnectionUrl=scm:git:https://gitlab.com/fake/r365-autoconfig.git -Dtag=0.1.14 -DuseReleaseProfile=false

Replacing the connectionUrl with correct SCM and required tag. I have tested that it works with both localCheckout set to true and false

@@ -46,7 +46,7 @@
*/
@Mojo( name = "perform", aggregator = true, requiresProject = false )
public class PerformReleaseMojo
extends AbstractReleaseMojo
extends AbstractScmReleaseMojo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #145 (comment). This exposes a lot more unused parameters, not just tag

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwin I see your point. What's the best course of action? Wait for 145 to be resolved, implement the changes suggested by 145, or just add tag property to perform release mojo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-o Please advise how to continue.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwin I see you commented on #145 to create 2 separate classes. I believe if they are created, this pull request may be made redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants