Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRELEASE-1022] Use versions defined in release.properties when doing release:prepare #111

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

sleberrigaud
Copy link
Contributor

this also works with version passed as arguments on the command line.

I was facing https://issues.apache.org/jira/browse/MRELEASE-1022, as trying to follow the documentation https://maven.apache.org/maven-release/maven-release-plugin/examples/non-interactive-release.html would not work (the multi-module & using properties file in particular)

I went and looked at the code, added test that would reproduce, and fixed them.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Please let me know if you'd rather I file a contributor license.

…ng `release:prepare`

this also works with version passed as arguments on the command line.
@olamy olamy added the bug label Apr 25, 2022
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olamy olamy merged commit eb2ac92 into apache:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants