Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRELEASE-1084] Upgrade Maven to 3.2.5 #106

Closed
wants to merge 3 commits into from
Closed

Conversation

michael-o
Copy link
Member

@cstamas This one is incomplete, need to swap classes.

@michael-o michael-o requested a review from cstamas April 15, 2022 10:57
@slachiewicz
Copy link
Member

maybe first move to 3.1 ?

@michael-o
Copy link
Member Author

maybe first move to 3.1 ?

I don't see a need because this is a major version and it has been neglected for years.
This PR is my first try to move to 3.5.4. You van provide a PR to go to 3.2.5 first, but I see zero reason to do 3.1.

@slachiewicz
Copy link
Member

ofc final can be 3.5 but we already know how to do a good upgrade to 3.1. Small steps.

@michael-o
Copy link
Member Author

ofc final can be 3.5 but we already know how to do a good upgrade to 3.1. Small steps.

Then go to 3.2.5 first and let's leave this as draft for now.

@slachiewicz
Copy link
Member

yeap - I mean 3.2.5 but fingers pressed 3.1. So that's now open for volunteer

@michael-o
Copy link
Member Author

@cstamas Do you want to pick this up and rather move to Maven 3.2.5?

@cstamas
Copy link
Member

cstamas commented Apr 28, 2022

Ok, I may pick this one up, is issue https://issues.apache.org/jira/browse/MRELEASE-1084 correct, or it needs to be edited to say 3.2.5? Or create new issuie?

@michael-o
Copy link
Member Author

Ok, I may pick this one up, is issue https://issues.apache.org/jira/browse/MRELEASE-1084 correct, or it needs to be edited to say 3.2.5? Or create new issuie?

Let edit it to 3.2.5 simply

@hboutemy hboutemy changed the title [MRELEASE-1084] Upgrade Maven to 3.5.4 [MRELEASE-1084] Upgrade Maven to 3.2.5 May 5, 2022
@cstamas
Copy link
Member

cstamas commented May 5, 2022

Isn't this superseded by #118 ?

@cstamas
Copy link
Member

cstamas commented May 5, 2022

Am closing this out, please reopen if needed

@cstamas cstamas closed this May 5, 2022
@cstamas cstamas deleted the MRELEASE-1084 branch May 5, 2022 08:51
asfgit pushed a commit that referenced this pull request Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants