Bump maven-shared-resources from 2 to 4 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [maven-shared-resources](https://github.com/apache/maven-shared-resources) from 2 to 4. - [Release notes](https://github.com/apache/maven-shared-resources/releases) - [Commits](https://github.com/apache/maven-shared-resources/commits) --- updated-dependencies: - dependency-name: org.apache.maven.shared:maven-shared-resources dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
cstamas
approved these changes
Oct 14, 2021
slachiewicz
approved these changes
Oct 15, 2021
cstamas
deleted the
dependabot/maven/org.apache.maven.shared-maven-shared-resources-4
branch
|
Looks like this commit broke the build, see https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/ |
|
Yup, so maven-shared-resources 3+ has this commit: But according to doco https://checkstyle.sourceforge.io/config_filefilters.html#BeforeExecutionExclusionFileFilter |
cstamas
added a commit
that referenced
this pull request
Oct 20, 2021
This reverts commit be57b24. As maven-shared-resources 3+ has this commit: apache/maven-shared-resources@5fbc3eb That according to doco https://checkstyle.sourceforge.io/config_filefilters.html#BeforeExecutionExclusionFileFilter is "since 7.2", while maven-checkstyle-plugin:3.0.0 uses checkstyle 6.18 Moreover, maven-shared-resources 4+ has this commit: apache/maven-shared-resources@fbef6f6 that requires checkstyle 8.42+ Currently there is no release of maven-checkstyle-plugin that uses checkstyle 8.42+ hence reverting this commit.
|
Pushed revert c468598 |
|
Yes, together we can use newer checkstyle plugin 3.1.2 http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps maven-shared-resources from 2 to 4.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)