Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkstyle.violation.ignore #183

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

slawekjaranowski
Copy link
Member

Ignore rules should be defined by project, class, method ... or we should drop a rule from configuration at all.

Ignored rules are still present in checkstyle report.

@slawekjaranowski
Copy link
Member Author

@slawekjaranowski
Copy link
Member Author

Even more looks like by this property violation is only removed from checking but still exist in site report

When we use @SuppressWarnings annotation in code it is removed from checking and from raport.

@slawekjaranowski slawekjaranowski added this to the MAVEN-43 milestone Jun 8, 2024
Ignore rules should be defined by project, class, method ...
or we should drop a rule from configuration at all.

Ignored rules are still present in checkstyle report.
@slawekjaranowski slawekjaranowski merged commit 10448b6 into master Jun 12, 2024
29 of 32 checks passed
@slawekjaranowski slawekjaranowski deleted the rm-checkstyle-ignore branch June 12, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants