[MSHARED-1007] Add MavenHome and MavenExecutable options to InvocationRequest #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested changes
Dec 29, 2021
| /** | ||
| * Sets the path to the base directory of the Maven installation used to invoke Maven. This parameter may be left | ||
| * unspecified to use the default Maven installation which will be discovered by evaluating the system property | ||
| * <code>maven.home</code> and the environment variable <code>M2_HOME</code>. |
There was a problem hiding this comment.
The M2_HOME variable is long dead. Don't use it.
| if ( mavenHome == null ) | ||
| { | ||
| String mavenHomeProperty = System.getProperty( "maven.home" ); | ||
| if ( mavenHomeProperty == null && getSystemEnvVars().getProperty( "M2_HOME" ) != null ) |
|
There is issue for removing M2_HOME - https://issues.apache.org/jira/browse/MSHARED-577 If it is only this remarks I will merge this PR and in separate change remove all occurrence of M2_HOME |
michael-o
reviewed
Dec 29, 2021
src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java
Show resolved
Hide resolved
Go ahead an then remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.