Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDEP-437] - mdep.link=true creates symlink instead of physical copy #87

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mkarg
Copy link
Contributor

@mkarg mkarg commented Jul 29, 2020

This PR proposes an implementation of [MDEP-437]: It provides a new property mdep.link=true (default is false) which lets the copy mojo produce symlinks instead of physical copies.

The benefit is that the user of this mojo now has control whether to invest time and space for real copies, or whether to spare it and just live with symbolic links.

@michael-o
Copy link
Member

How is this IT supposed to pass on Windows?

@mkarg
Copy link
Contributor Author

mkarg commented Jul 30, 2020

How is this IT supposed to pass on Windows?

We could simply skip it.

@mkarg mkarg marked this pull request as ready for review August 28, 2020 22:03
@mkarg mkarg marked this pull request as draft August 28, 2020 22:03
@mkarg
Copy link
Contributor Author

mkarg commented Aug 28, 2020

How is this IT supposed to pass on Windows?

I have added a check that (as best as it can) solves the problem with Windows by checking if symlinks are supported at all. Test drive with Linux and Windows worked well. @michael-o WDYT?

@mkarg
Copy link
Contributor Author

mkarg commented Sep 5, 2020

As there had been no further change requests, I hereby ask everybody for review. :-)

@mkarg mkarg marked this pull request as ready for review September 5, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants