[MDEP-650] - dependency:unpack doesn't seem to handle version ranges #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck" goal - add tests and improve error handling
…ck" goal - add tests and improve error handling
…- correct file name
Change the snapshot version in the pom.xml file to allow for internal use while the pull request is considered.
|
Can you please first squash your changes...into a single commit ...so it's easier to take a look at it... |
asfgit
pushed a commit
that referenced
this pull request
Sep 29, 2021
[MGPG-80] implement GpgVersion equality in adherence to comparibility
elharo
requested changes
Oct 13, 2024
| @@ -30,7 +30,7 @@ under the License. | |||
| </parent> | |||
|
|
|||
| <artifactId>maven-dependency-plugin</artifactId> | |||
| <version>3.1.2-SNAPSHOT</version> | |||
| <version>3.1.1.alehane-SNAPSHOT</version> | |||
| * If the dependency is not found or the range does not match, then the version | ||
| * is not changed. | ||
| * | ||
| * @param artifactItem The artifact item to update, if required. |
There was a problem hiding this comment.
nit: the artifact item to update, if required
per oracle javadoc conventions
| @Override | ||
| protected void tearDown() | ||
| { | ||
| super.tearDown(); |
| @@ -0,0 +1,98 @@ | |||
| package org.apache.maven.plugins.dependency.testUtils.stubs; | |||
|
|
|||
| @Override | ||
| public Artifact getArtifact() | ||
| { | ||
| // TODO Auto-generated method stub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to enable version range resolution for the dependency:unpack goal by first checking to see whether the version range has already been resolved by the project's dependency resolution. If there is no resolution, attempt to use the DependencyResolver maven component to resolve the range. If resolution is successful, then update the artifactItem object with the resolved version, otherwise, leave the version un-changed.
Tests and verification:
Licence info:
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.