Skip to content

fix(desktop): fresh sweep on new tip — restraint consistency, bot primary, honest fade #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackwener merged 1 commit into from
Jul 11, 2026
Merged

fix(desktop): fresh sweep on new tip — restraint consistency, bot primary, honest fade #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/desktop/src/renderer/settings/bot-chat-settings-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,8 +780,9 @@ export function BotChatSettingsPage(props: {
</>
) : support === 'runtime' && !selectedStatus?.running ? (
<Button
// One primary per view: 测试并连接 is the form's completion
// action — the page previously had no primary at all.
type="button"
variant="secondary"
disabled={botActionBusy}
onClick={testAndConnect}
>
Expand Down
4 changes: 3 additions & 1 deletion apps/desktop/src/renderer/styles/onboarding.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,9 @@
left: var(--border-width-hairline);
right: var(--border-width-hairline);
bottom: var(--border-width-hairline);
height: 28px;
/* 56px: tall enough to fully veil a half-clipped row's text — at 28px the
cut row stayed half-legible under the fade and still read as broken. */
height: 56px;
border-radius: 0 0 var(--radius-surface) var(--radius-surface);
background: linear-gradient(to bottom, oklch(from var(--background-elevated) l c h / 0), var(--background-elevated));
pointer-events: none;
Expand Down
4 changes: 3 additions & 1 deletion packages/ui/src/daily-review-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ const EMPTY_MODEL_OPTIONS: ReadonlyArray<readonly [string, string]> = [];
// no_model = the run could not produce a report (destructive). no_data /
// skipped are expected non-events and stay neutral (exception-only color).
function dailyReviewArchiveChipTone(status: DailyReviewArchive['status']): ChipProps['variant'] {
if (status === 'ok') return 'success';
// Status-color restraint (#651 rule): 已生成 is the EXPECTED outcome —
// neutral ink, matching 健康 正常 and 权限 已授权. Color stays reserved
// for the failures that need attention.
if (status === 'failed' || status === 'no_model') return 'destructive';
return 'neutral';
}
Expand Down
Loading