ci: report lint and format before the arch gate - #4913
Conversation
The renderer architecture gate takes about 53s, so a diff that only breaks formatting waited on it before the sub-second checks reported. Neither ordering is a dependency. Generated-by: Claude Code
8ca7d8f to
c9c381e
Compare
hqhq1025
left a comment
There was a problem hiding this comment.
No substantiated findings at c9c381e. The complete diff only moves the lint and formatting steps before the renderer architecture gate (.github/workflows/ci.yml:217–236). Their conditions, commands, the architecture BASE_SHA handling, and the remaining workflow are unchanged; installation still precedes these checks.
Validation: 76 CI-policy/planner tests pass. Independently executing the extracted shell commands with controlled failures confirms that lint/format failures now prevent the expensive architecture step, while an architecture failure still fails the run. Empty, zero and valid BASE_SHA branches preserve the same commands. This verifies ordering, not the claimed numerical runtime savings or GitHub-hosted engine execution. No code blocker found within this scope; this is not an approval.
Automated review notice: This comment was posted by an automated review agent operated by hqhq1025. It is not an independent human review and does not replace one.
Astro-Han
left a comment
There was a problem hiding this comment.
Thanks for the change. Approving exact head c9c381e947ea9ec717d9cf4413363bf7dca95994 following the completed review and Astro-Han’s explicit acceptance of this merge batch. Current checks pass and no review threads remain unresolved.
Formatting-only failures waited behind the slower renderer architecture gate. Run lint and formatting first while preserving every step condition and environment. No product or compatibility behavior changes.
AI assistance: Codex performed the review and final-state verification; Astro-Han authorized approval and merge.
中文
感谢改动。基于已完成的审查和 Astro-Han 对本批次的明确认可,批准当前精确 head;检查通过,讨论已结清。此前说明的验证边界与后续事项保持不变。本次由 Codex 执行审查和状态核对,Astro-Han 授权批准与合并。
Summary
Check renderer architectureruns for about 53s and sat ahead ofLintandCheck formatting, which finish in under a second each. A diff whose onlyproblem was a formatting slip therefore paid the architecture gate before CI
told it anything. Moving the two fast checks ahead reports that class of failure
about a minute sooner.
Neither ordering is a dependency: all three run after
npm ci, and thearchitecture gate reads the working tree rather than any lint output. Green runs
are unaffected — this only changes when a failing run reports.
Verification
Step order after the move:
Review focus
The
if:conditions,env:, and the comment above the architecture gate movewith their steps unchanged; the diff is a relocation, not an edit.
AI use
Select exactly one:
Tool(s) and scope: Claude Code measured the step costs, spotted the inversion,
and wrote the workflow edit and this description. Reviewed by the author.
Checklist
nothing fails without this edit
Does this PR entail a change in behavior?