Skip to content

ci: report lint and format before the arch gate - #4913

Merged
Astro-Han merged 1 commit into
apache:mainfrom
orangeCatDeveloper:ci/lint-before-architecture-gate
Sep 7, 2026
Merged

Astro-Han merged 1 commit into
apache:mainfrom
orangeCatDeveloper:ci/lint-before-architecture-gate

Conversation

@orangeCatDeveloper

Copy link
Copy Markdown
Contributor

Summary

Check renderer architecture runs for about 53s and sat ahead of Lint and
Check formatting, which finish in under a second each. A diff whose only
problem was a formatting slip therefore paid the architecture gate before CI
told it anything. Moving the two fast checks ahead reports that class of failure
about a minute sooner.

Neither ordering is a dependency: all three run after npm ci, and the
architecture gate reads the working tree rather than any lint output. Green runs
are unaffected — this only changes when a failing run reports.

Verification

$ node --test --test-concurrency=1 scripts/ci-workflow-policy.test.mjs scripts/ci-test-plan.test.mjs
ℹ tests 76
ℹ pass 76
ℹ fail 0

Step order after the move:

- name: Lint
- name: Check formatting
- name: Check renderer architecture

Review focus

The if: conditions, env:, and the comment above the architecture gate move
with their steps unchanged; the diff is a relocation, not an edit.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Claude Code measured the step costs, spotted the inversion,
and wrote the workflow edit and this description. Reviewed by the author.

Checklist

  • Tests cover the change and fail without it — no test pins step order, so
    nothing fails without this edit
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actions github-actions Bot added the effort/S Under 100 readable lines label Sep 6, 2026
The renderer architecture gate takes about 53s, so a diff that only breaks
formatting waited on it before the sub-second checks reported. Neither
ordering is a dependency.

Generated-by: Claude Code
@orangeCatDeveloper
orangeCatDeveloper force-pushed the ci/lint-before-architecture-gate branch from 8ca7d8f to c9c381e Compare September 6, 2026 11:01

@hqhq1025 hqhq1025 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No substantiated findings at c9c381e. The complete diff only moves the lint and formatting steps before the renderer architecture gate (.github/workflows/ci.yml:217–236). Their conditions, commands, the architecture BASE_SHA handling, and the remaining workflow are unchanged; installation still precedes these checks.

Validation: 76 CI-policy/planner tests pass. Independently executing the extracted shell commands with controlled failures confirms that lint/format failures now prevent the expensive architecture step, while an architecture failure still fails the run. Empty, zero and valid BASE_SHA branches preserve the same commands. This verifies ordering, not the claimed numerical runtime savings or GitHub-hosted engine execution. No code blocker found within this scope; this is not an approval.

Automated review notice: This comment was posted by an automated review agent operated by hqhq1025. It is not an independent human review and does not replace one.

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Approving exact head c9c381e947ea9ec717d9cf4413363bf7dca95994 following the completed review and Astro-Han’s explicit acceptance of this merge batch. Current checks pass and no review threads remain unresolved.

Formatting-only failures waited behind the slower renderer architecture gate. Run lint and formatting first while preserving every step condition and environment. No product or compatibility behavior changes.

AI assistance: Codex performed the review and final-state verification; Astro-Han authorized approval and merge.

中文

感谢改动。基于已完成的审查和 Astro-Han 对本批次的明确认可,批准当前精确 head;检查通过,讨论已结清。此前说明的验证边界与后续事项保持不变。本次由 Codex 执行审查和状态核对,Astro-Han 授权批准与合并。

@Astro-Han
Astro-Han merged commit 943510c into apache:main Sep 7, 2026
1 check passed
@orangeCatDeveloper
orangeCatDeveloper deleted the ci/lint-before-architecture-gate branch September 7, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/S Under 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants