fix(i18n): emit settings expected-result codes from producers

[orangeCatDeveloper]

Summary

Settings-area producers emitted zh-only result strings, so English users either saw Chinese or — where consumers guarded with /[㐀-鿿]/ content sniffing — silently lost the information (permission guidance was dropped entirely). Producers now emit stable machine codes (IPC payloads stay locale-free), and each settings catalog maps its union exhaustively per locale with an explicit unknown-code fallback. CJK sniffing was removed where this PR code-ified the producer. zh copy moved verbatim, en copy is new.

Covered producers: capability-snapshot reasons, memory ops, test-connection OAuth rate-limit, computer-use-host health reasons, the GitHub Copilot import path (github-copilot-local-credential + its IPC handler, re-based onto main's device-grant rewrite), plus the dev-singleton dialog, browser message-box close label, and artifact/config native dialog titles (wired through the main-process locale authority). subscriptionResultMessage now takes the result envelope and resolves code, then the typed reason (experimental_disabled), through the catalog before falling back to the keyword classifier; its trailing CJK passthrough is gone. It moved out of the useOAuthLoginFlow hook module into the catalog module beside the copy it renders, which also makes it testable from node.

The bot domain moved to its own PR so each PR is one reviewer context.

Memory messages now use complete per-locale templates instead of a shared sentence skeleton with translated fragments. The typed catalog owns counts, summaries, redaction notices, backup failures, and preview/action descriptions; existing wording and pluralization are preserved.

The Permission Center's guidance block is removed in this PR: no producer fills guidance after the code-ification, and #4526's layered rows carry the actionable lines (cuBackendStatus composition), so the dead column is dropped — its locale keys, the storybook fixture's zh guidance line, and the collapsed-story comment referencing the block are all gone.

Refs #2672

Verification

apps/desktop typecheck (4 tsconfigs):   0 errors
workspace typecheck:                    0 errors
desktop main tests (dist):              2209 pass / 0 fail
rendered-output tests (en+zh):          Copilot code, memory rejection codes, experimental_disabled reason, unknown code → fallback
packages/core tests:                    818 pass / 0 fail
CJK-sniff regexes in touched files:     0 (provider action fallback reworded to the locale fallback)
zh literals in copilot producers:       0 remaining (was 8)
renderer architecture check:            passed against origin/main
biome (changed files):                  clean
check:tui-copy:                         ok

Boundaries: one capability-reason-copy.ts catalog serves the Health center and the Permission Center; the three prose reason tokens are now platform_credentials_missing, macos_tcc_only and apple_events_tcc_status_unavailable. Bot capability reasons resolve through #4639's botStatusReasonCopy. The rate-limited connection test keeps its guidance keyed on statusCode === 429, the same stable signal the command palette already uses, rather than widening ConnectionTestErrorClass across the codec, CLI, and renderer. subscriptionResultMessage still matches three English Host messages (enrollment is disabled, already in progress, did not present OAuth) as a fallback for Hosts that predate the codes; an unclassified Host message renders the locale fallback rather than the raw text, per the locale policy in #2672. The storybook smoke keeps its full-sentence match on purpose: storybook-visual-smoke.test.mjs requires unrelated settings errors in the error story to stay fatal. Permission probe failures collapse to permission_probe_failed for the page, and the raw cause is kept observable via a console.warn in capability-snapshot.ts so the closed code does not swallow the diagnostic.

Follow-up verification: all 13 memory-copy and label tests pass, with exact formatted-output coverage across all three locales, draft states, singular/plural counts, archived entries, backup kinds, and preview messages. Desktop build and all four typechecks, repository format/lint, and the renderer architecture check pass.

AI use

Select exactly one:

• No generative tool made a substantive contribution
• Generative tooling made a substantive contribution

Tool(s) and scope: Claude Code, Muse Spark, and OpenCode — analysis, implementation, review fixes, tests, and this description, under the contributor's direction; each affected commit carries the corresponding Generated-by trailer.

OpenCode also implemented the complete memory-message templates and their output tests, and updated this description.

Checklist

• Tests cover the change and fail without it

[orangeCatDeveloper]

@Astro-Han All issues are addressed in the latest commit

[orangeCatDeveloper]

@Astro-Han Rebased and CI is green again

[Astro-Han]

I reviewed this PR at head 8ccee58b (50 files, +1138/−443) against base bd3646b3, and re-verified every finding from the earlier review (which was bound to the older head af07077c) against the current code.

What the change does: settings-area producers stop emitting zh-only result strings and now emit stable machine codes; each settings catalog maps its union exhaustively per locale with an explicit unknown-code fallback. Covered producers: capability-snapshot reasons, memory operations, OAuth rate-limit test results, Computer Use host health, the GitHub Copilot import path, plus native dialog titles wired through the main-process locale authority.

Prior-review findings, re-verified at this head:

• P1 (two parallel three-locale reason tables saying different things) — fixed. One shared capability-reason-copy.ts holds a single Record<CapabilityReasonCode, string> per locale; the Health center reads it via capabilityReasonMessage and the Permission Center via getCapabilityReasonCopy, and permission-center-copy.ts keeps only its cuBackendStatus composition. No duplicated 23×3 tables remain.
• P2 (Permission Center losing bot capability reasons) — fixed. capabilityReasonText routes bot:* capabilities through botStatusReasonCopy (post-#4639) before falling back.
• P2 (three prose reason tokens) — fixed. The tokens are now snake_case (platform_credentials_missing, macos_tcc_only, apple_events_tcc_status_unavailable), including in the e2e fixture.
• P2 (subscriptionResultMessage dropping an unclassified Host reason) — deliberately diverged, with justification. The review asked to keep a raw-text pass-through as the last step; the author instead routes unclassified messages through the localized classifier and then the locale fallback, citing the #2672 locale policy (do not show untranslated raw text). The resolution order is preserved: code → typed reason → three legacy English Host matches → classifier → fallback (settings-provider-copy.ts:672-686). The loss is bounded to genuinely unclassifiable Host messages, which are rare; I record this as a P3 for human confirmation rather than a blocker.
• Smaller items — all landed. The 429 rate-limit guidance is preserved renderer-side keyed on the stable statusCode === 429 signal (provider-panel-shared.ts:58); the memory IPC and Copilot IPC emit typed code instead of raw/Chinese message (dead field removed); the unused guidance plumbing is deleted outright (commit c04ded5d4); the e2e fixture emits the closed code; native dialog titles use a UiCatalog in the main process; the classifier gains net::err network-error classification.

New scope spot-check: the memory copy is a complete typed catalog (~150 keys × three locales plus results keyed by MemoryResultCode), covered by settings-memory-copy.test.ts; the OAuth/Copilot/dialog producers follow the same code-plus-catalog pattern. CI on this exact head is fully green (Build, Typecheck, affected workspace tests, Desktop e2e, Storybook smoke, Lint).

P3 (recorded): the unclassified-Host-message divergence above (English users may see a generic localized line instead of the Host's specific reason; bounded); and the Storybook smoke still matches the expected console line by full text (isExpectedConsoleError, with its own test) rather than the [settings] prefix — intentional so a changed error story fails the smoke, but it stays brittle to wording changes.

Not verified: I did not re-read every one of the ~150 memory template strings line by line for copy quality (structure is sound, CI green, tests cover exact output); I did not run the suites locally (CI on the exact head covers them). A manual pass over the three locales — Health vs Permission Center rendering the same capability identically, a failed bot row, and a memory save with counts — is worth doing before merge.

No P0–P2 findings. This is a behavior-changing fix; I am not approving — the merge decision belongs to humans.

---

Automated review notice: This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.

[orangeCatDeveloper]

Thanks — that matches what I intended, and I did the manual three-locale pass you asked for before merge. Both P3s are deliberate.

[Astro-Han]

Thanks for confirming the three-locale manual pass and the intentional P3 tradeoffs. The head remains 8ccee58b6, which was already reviewed without P0–P2 findings. Current CI is green, there are no unresolved threads, and the maintainer has confirmed proceeding with the merge.

AI-assisted source/integration review; the manual locale check was reported by the contributor, not rerun by this agent.

中文

感谢确认已完成三语言人工验收及两项 P3 的取舍。head 仍是此前无 P0–P2 的 8ccee58，当前 CI 绿色、无未解决讨论，维护者已确认合并。本轮为 AI 辅助源码/整合评审；三语言人工检查由贡献者报告，并非本代理重新执行。