-
Notifications
You must be signed in to change notification settings - Fork 507
refactor(design-system): converge status surfaces and the radius ladder onto Astryx's token seams #4465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
refactor(design-system): converge status surfaces and the radius ladder onto Astryx's token seams #4465
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
23e9f74
refactor(design-system): converge status surfaces onto Astryx's muted…
Astro-Han 698f5fb
refactor(design-system): alias Astryx's radius rungs to the product's…
Astro-Han 2c72c4e
docs(design-system): state the control-height ladder's offset against…
Astro-Han 01bcc85
refactor(desktop): drop the sidenav hairline the shell already cancels
Astro-Han 562e9f8
test(storybook): run the render smoke in both colour schemes
Astro-Han 67b5072
docs(design-system): record --color-text-disabled as a deliberate AA …
Astro-Han 419ba0b
fix(ui): give the informational tint its siblings' construction
Astro-Han 4fbc4b9
fix(ui): restore AA on the five surfaces the heavier tint moved
Astro-Han File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: this paragraph says
--color-accent-mutedis one 0.24 construction and that a hand-rolledoklch(...)at a call site is forbidden. Five live Astryx mount seams still re-declare it at 0.12:Those subtrees never inherit the unlayered 0.24 bridge, so composer and inspector selection / muted fills stay a second rung. Either drop the local muted pin so they inherit, or record the exemption the way the about-page brand plate is recorded.
简体中文
P2:这里写
--color-accent-muted只有 0.24 一档。astryx-mount.css里五处 Astryx 接缝仍钉成 0.12,composer/inspector 不会继承 0.24。删掉这行让它继承,或者像 about 页品牌底板那样把豁免写清楚。