perf(desktop): bound rendering within oversized turns

apps/desktop/e2e/fixtures.ts

@@ -498,6 +498,7 @@ export const test = base.extend<{
   railRenderWindow: Page;
   promptRailWindow: Page;
   partialHistoryWindow: Page;
+  oversizedTurnWindow: Page;
   promptRailMotionWindow: Page;
   requestHeaderRowWindow: Page;
   newTaskTargetWindow: Page;
@@ -615,6 +616,17 @@ export const test = base.extend<{
       showWindow: true,
     }, use);
   },
+  // One Turn larger than the transcript byte budget. Shown because the test
+  // reads Chromium's actual content-visibility state while crossing it.
+  oversizedTurnWindow: async ({}, use) => {
+    await withE2eWindow({
+      seed: false,
+      readinessSelector: '[data-turn-id="turn-oversized-fixture"]',
+      e2eFixtureScenario: 'chat-oversized-turn',
+      locale: 'zh',
+      showWindow: true,
+    }, use);
+  },
   // The same transcript, scrolling the way the shipped app scrolls. Separate
   // from `promptRailWindow` because it is only the jump that needs a scroll
   // still in flight, and paying for one everywhere costs several seconds per

apps/desktop/e2e/native-transcript-perf.spec.ts

@@ -24,6 +24,10 @@ import { ensureSidebarExpanded, expect, test } from './fixtures';
 
 const PERF_ENABLED = process.env.MAKA_TRANSCRIPT_PERF === '1';
 const STRESS_ENABLED = process.env.MAKA_TRANSCRIPT_STRESS === '1';
+// Long-animation-frame delivery includes the native compositor. Xvfb's
+// software/virtual display is useful for functional E2E, but is not comparable
+// to the macOS arm64 environment in which this release threshold was measured.
+const NATIVE_MACOS_ARM64_PERF_GATE = process.platform === 'darwin' && process.arch === 'arm64';
 const SCROLLER = '[data-chat-scroll-container="true"]';
 
 interface BrowserCounters {
@@ -323,6 +327,61 @@ test('warm native transcript scroll metrics', async ({ promptRailWindow: page })
   console.log(`TRANSCRIPT_PERF ${JSON.stringify(result)}`);
 });
 
+test('oversized single Turn upward scroll metrics', async ({
+  oversizedTurnWindow: page,
+}) => {
+  test.skip(!PERF_ENABLED, 'manual same-build CDP oversized-Turn harness');
+  test.skip(
+    !NATIVE_MACOS_ARM64_PERF_GATE,
+    '50 ms release gate is calibrated for native macOS arm64, not Linux/Xvfb',
+  );
+  test.setTimeout(90_000);
+  await page.setViewportSize({ width: 1_000, height: 700 });
+  await expect(page.locator('[data-turn-id="turn-oversized-fixture"]')).toHaveCount(1);
+  const cdp = await page.context().newCDPSession(page);
+  await cdp.send('Performance.enable');
+  await prepareFrameRecorder(page);
+  await moveToTail(page);
+  const distance = await page.evaluate((selector) => {
+    const root = document.querySelector<HTMLElement>(selector);
+    if (!root) throw new Error('the chat scroll container is missing');
+    return root.scrollHeight - root.clientHeight;
+  }, SCROLLER);
+  const before = await performanceMetrics(cdp);
+  const frames = await scrollGesture(page, -distance, 480);
+  const after = await performanceMetrics(cdp);
+  const skippedSegments = await page.locator([
+    '.maka-assistant-answer-content > .maka-chat-message-bubble-assistant',
+    '.maka-assistant-answer-content > .maka-processing-sequence',
+    '.maka-processing-sequence > *',
+  ].join(',')).evaluateAll((elements) =>
+    (elements as HTMLElement[]).filter((element) =>
+      !element.checkVisibility({ contentVisibilityAuto: true })).length,
+  );
+  const result = {
+    distance,
+    taskMs: metricDelta(before, after, 'TaskDuration') * 1_000,
+    layoutMs: metricDelta(before, after, 'LayoutDuration') * 1_000,
+    recalcStyleMs: metricDelta(before, after, 'RecalcStyleDuration') * 1_000,
+    frameP95Ms: percentile(frames.intervals, 0.95),
+    frameP99Ms: percentile(frames.intervals, 0.99),
+    frameMaxMs: Math.max(...frames.intervals),
+    loafOver50Ms: frames.loafDurations.filter((duration) => duration > 50).length,
+    loafMaxMs: Math.max(0, ...frames.loafDurations),
+    loafSupported: frames.loafSupported,
+    skippedSegments,
+  };
+  console.log(`OVERSIZED_TURN_PERF ${JSON.stringify(result)}`);
+  expect(
+    frames.loafSupported,
+    'Chromium does not support the long-animation-frame release metric',
+  ).toBe(true);
+  expect(
+    result.loafOver50Ms,
+    `oversized-Turn upward scroll exceeded the 50 ms Long Animation Frame gate: ${JSON.stringify(result)}`,
+  ).toBe(0);
+});
+
 test('600+ Turn repeated paging keeps the active range on a memory plateau', async ({
   promptRailWindow: page,
 }) => {

apps/desktop/e2e/oversized-turn-render.spec.ts

@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { expect, test } from './fixtures';
+
+const SEGMENT = [
+  '.maka-assistant-answer-content > .maka-chat-message-bubble-assistant',
+  '.maka-assistant-answer-content > .maka-processing-sequence',
+  '.maka-processing-sequence > *',
+].join(',');
+const SCROLLER = '[data-chat-scroll-container="true"]';
+
+async function waitForPaintedFrames(page: import('@playwright/test').Page, frames = 4) {
+  await page.evaluate(async (count) => {
+    for (let frame = 0; frame < count; frame += 1) {
+      await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+    }
+  }, frames);
+}
+
+test('an oversized single Turn skips offscreen timeline blocks', async ({
+  oversizedTurnWindow: page,
+}) => {
+  await page.setViewportSize({ width: 900, height: 700 });
+  const segments = page.locator(SEGMENT);
+  await expect(segments).not.toHaveCount(0);
+  expect(await segments.count()).toBeGreaterThan(80);
+
+  const state = await segments.evaluateAll((elements) => {
+    const rows = elements as HTMLElement[];
+    return {
+      automatic: rows.filter((element) =>
+        getComputedStyle(element).contentVisibility === 'auto').length,
+      skipped: rows.filter((element) =>
+        !element.checkVisibility({ contentVisibilityAuto: true })).length,
+    };
+  });
+  expect(state.automatic).toBe(await segments.count());
+  expect(state.skipped).toBeGreaterThan(0);
+
+  const first = segments.first();
+  await first.evaluate((element) => element.scrollIntoView({ block: 'center' }));
+  await page.evaluate(() => new Promise<void>((resolve) =>
+    requestAnimationFrame(() => requestAnimationFrame(() => resolve())),
+  ));
+  expect(await first.evaluate((element) =>
+    element.checkVisibility({ contentVisibilityAuto: true }),
+  )).toBe(true);
+});
+
+test('upward scrolling releases the live tail while skipped geometry materializes', async ({
+  oversizedTurnWindow: page,
+}) => {
+  await page.setViewportSize({ width: 900, height: 700 });
+  const root = page.locator(SCROLLER);
+  await root.evaluate((element) => {
+    element.scrollTop = element.scrollHeight;
+  });
+  await waitForPaintedFrames(page);
+
+  const atTail = await root.evaluate((element) =>
+    element.scrollHeight - element.scrollTop - element.clientHeight,
+  );
+  expect(atTail).toBeLessThanOrEqual(4);
+
+  // Force the ordering from the field report: the wheel begins materializing
+  // an intrinsic-size block before Chromium delivers the resulting scroll.
+  // Appending below the reader is deterministic synthetic growth; approaching
+  // the skipped timeline blocks above adds the real content-visibility change.
+  await root.evaluate((element) => {
+    const list = element.querySelector('.maka-chat-message-list');
+    if (!list) throw new Error('the transcript content box is missing');
+    element.addEventListener('wheel', () => {
+      const growth = document.createElement('div');
+      growth.dataset.oversizedTurnGrowth = 'true';
+      growth.style.height = '600px';
+      list.append(growth);
+    }, { capture: true, once: true });
+  });
+
+  await root.hover();
+  await page.mouse.wheel(0, -500);
+  await waitForPaintedFrames(page, 6);
+
+  const released = await root.evaluate((element) => ({
+    distance: element.scrollHeight - element.scrollTop - element.clientHeight,
+    top: element.scrollTop,
+  }));
+  expect(released.distance).toBeGreaterThan(100);
+
+  // A later delivery must preserve the released position too. Without the
+  // release, the scroll authority writes the latest tail on this resize.
+  await root.evaluate((element) => {
+    const growth = element.querySelector<HTMLElement>('[data-oversized-turn-growth]');
+    if (!growth) throw new Error('the synthetic growth box is missing');
+    growth.style.height = '900px';
+  });
+  await waitForPaintedFrames(page);
+
+  const afterGrowth = await root.evaluate((element) => ({
+    distance: element.scrollHeight - element.scrollTop - element.clientHeight,
+    top: element.scrollTop,
+  }));
+  expect(afterGrowth.distance).toBeGreaterThan(released.distance);
+  expect(Math.abs(afterGrowth.top - released.top)).toBeLessThanOrEqual(4);
+});
+
+test('keyboard focus into a skipped card releases the live tail', async ({
+  oversizedTurnWindow: page,
+}) => {
+  await page.setViewportSize({ width: 900, height: 700 });
+  const root = page.locator(SCROLLER);
+  await root.evaluate((element) => {
+    element.scrollTop = element.scrollHeight;
+  });
+  await waitForPaintedFrames(page);
+
+  const boundary = await root.evaluate((element, segmentSelector) => {
+    // Use the actual sequential focus order inside the transcript. The
+    // containment boundary is the tool-card row around Astryx's native button,
+    // so visibility must be asked of that row rather than its focused child.
+    const headers = [...element.querySelectorAll<HTMLElement>('[role="button"][tabindex="0"]')]
+      .map((header) => ({ header, row: header.closest<HTMLElement>(segmentSelector) }))
+      .filter((entry): entry is { header: HTMLElement; row: HTMLElement } =>
+        entry.row != null,
+      );
+    for (let index = 1; index < headers.length; index += 1) {
+      const previous = headers[index - 1]!;
+      const anchor = headers[index]!;
+      if (
+        !previous.row.checkVisibility({ contentVisibilityAuto: true })
+        && anchor.row.checkVisibility({ contentVisibilityAuto: true })
+      ) {
+        previous.header.dataset.focusBoundaryTarget = 'true';
+        anchor.header.dataset.focusBoundaryAnchor = 'true';
+        anchor.header.focus({ preventScroll: true });
+        return { found: true, headerCount: headers.length };
+      }
+    }
+    return { found: false, headerCount: headers.length };
+  }, SEGMENT);
+  expect(boundary.headerCount).toBeGreaterThan(5);
+  expect(boundary.found).toBe(true);
+
+  // This is the normal sequential-navigation path, not a synthetic focus
+  // event. Shift+Tab enters the immediately preceding skipped activity card.
+  await page.keyboard.press('Shift+Tab');
+  await waitForPaintedFrames(page, 6);
+
+  const focused = await root.evaluate((element) => {
+    const active = document.activeElement as HTMLElement | null;
+    const rootRect = element.getBoundingClientRect();
+    const activeRect = active?.getBoundingClientRect();
+    return {
+      target: active?.dataset.focusBoundaryTarget === 'true',
+      distance: element.scrollHeight - element.scrollTop - element.clientHeight,
+      top: element.scrollTop,
+      activeTop: activeRect?.top ?? Number.NaN,
+      withinViewport: activeRect != null
+        && activeRect.bottom > rootRect.top
+        && activeRect.top < rootRect.bottom,
+    };
+  });
+  expect(focused.target).toBe(true);
+  expect(focused.distance).toBeGreaterThan(100);
+  expect(focused.withinViewport).toBe(true);
+
+  // A later content delivery resizes the observed transcript box. It must not
+  // re-pin and move the focused card out from under keyboard/AT navigation.
+  await root.evaluate((element) => {
+    const list = element.querySelector('.maka-chat-message-list');
+    if (!list) throw new Error('the transcript content box is missing');
+    const growth = document.createElement('div');
+    growth.style.height = '600px';
+    list.append(growth);
+  });
+  await waitForPaintedFrames(page);
+
+  const afterGrowth = await root.evaluate((element) => {
+    const active = document.activeElement as HTMLElement | null;
+    return {
+      target: active?.dataset.focusBoundaryTarget === 'true',
+      distance: element.scrollHeight - element.scrollTop - element.clientHeight,
+      top: element.scrollTop,
+      activeTop: active?.getBoundingClientRect().top ?? Number.NaN,
+    };
+  });
+  expect(afterGrowth.target).toBe(true);
+  expect(afterGrowth.distance).toBeGreaterThan(focused.distance);
+  expect(Math.abs(afterGrowth.top - focused.top)).toBeLessThanOrEqual(4);
+  expect(Math.abs(afterGrowth.activeTop - focused.activeTop)).toBeLessThanOrEqual(4);
+});
+
+test('visible transcript focus during pending growth keeps the live tail', async ({
+  oversizedTurnWindow: page,
+}) => {
+  await page.setViewportSize({ width: 900, height: 700 });
+  const root = page.locator(SCROLLER);
+  await root.evaluate((element) => {
+    element.scrollTop = element.scrollHeight;
+  });
+  await waitForPaintedFrames(page);
+
+  await root.evaluate((element) => {
+    const list = element.querySelector('.maka-chat-message-list');
+    if (!list) throw new Error('the transcript content box is missing');
+    const rootRect = element.getBoundingClientRect();
+    const control = [...list.querySelectorAll<HTMLElement>('[role="button"][tabindex="0"]')]
+      .reverse()
+      .find((candidate) => {
+        const rect = candidate.getBoundingClientRect();
+        return rect.bottom > rootRect.top && rect.top < rootRect.bottom;
+      });
+    if (!control) throw new Error('no visible transcript control is available');
+
+    // Keep both mutations and focus in one task. ResizeObserver is therefore
+    // still pending when the visible control receives focus, which is the race
+    // where root distance must not be mistaken for reader movement.
+    const firstGrowth = document.createElement('div');
+    firstGrowth.dataset.pendingFocusGrowth = 'true';
+    firstGrowth.style.height = '600px';
+    list.append(firstGrowth);
+    control.focus();
+    const secondGrowth = document.createElement('div');
+    secondGrowth.dataset.followUpFocusGrowth = 'true';
+    secondGrowth.style.height = '300px';
+    list.append(secondGrowth);
+  });
+  await waitForPaintedFrames(page, 6);
+
+  const result = await root.evaluate((element) => ({
+    distance: element.scrollHeight - element.scrollTop - element.clientHeight,
+    activeInTranscript: Boolean(
+      document.activeElement?.closest('.maka-chat-message-list'),
+    ),
+  }));
+  expect(result.activeInTranscript).toBe(true);
+  expect(result.distance).toBeLessThanOrEqual(4);
+});