Skip to content

feat(cli): reconcile exact local Runtime Host restarts #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 3 commits into from
Aug 26, 2026
Merged

feat(cli): reconcile exact local Runtime Host restarts #3920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aea2a38
refactor(cli): share immutable Runtime Host package store
me2seeks Aug 26, 2026
c5ed3d9
feat(cli): stage exact local Runtime Host handoffs
me2seeks Aug 26, 2026
f6ab656
feat(cli): restart exact installed local Runtime Host
me2seeks Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions packages/cli/src/__tests__/runtime-host-cli-context.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ import {
RUNTIME_HOST_PROTOCOL_VERSION,
RUNTIME_HOST_REGISTRATION_SCHEMA_VERSION,
type HostIncompatible,
type HostRegistration,
} from '@maka/runtime-host/protocol';
import {
connectRuntimeHostCli,
resolveRuntimeHostCliConflictDecision,
RuntimeHostCliConflictError,
shouldRetryRuntimeHostConflict,
} from '../runtime-host-cli-context.js';
Expand Down Expand Up @@ -96,6 +98,31 @@ test('CLI Runtime Host bootstrap launches the execution composition', async () =
assert.equal(closes, 1);
});

test('CLI refuses a staged Host whose durable installation claim is missing', async () => {
let closes = 0;
await assert.rejects(
connectRuntimeHostCli(
{ rootPath: '/runtime-host-root' },
{
connectOrSpawn: async () => ({
kind: 'connected',
registration: hostRegistration({
generation: `npm-global-handoff:${'a'.repeat(64)}`,
}),
connection: {
close: async () => {
closes += 1;
},
} as RuntimeHostConnection,
}),
readDeploymentRecord: async () => undefined,
},
),
/RUNTIME_HOST_RECOVERY_REQUIRED/u,
);
assert.equal(closes, 1);
});

test('non-interactive CLI reports how to retire an incompatible Runtime Host', async () => {
assert.ok(RUNTIME_HOST_COMPATIBILITY_EPOCH > V0_1_11_HOST_COMPATIBILITY_EPOCH);
await assert.rejects(
Expand Down Expand Up @@ -181,6 +208,11 @@ test('Runtime Host conflict waits only after an explicit wait answer', () => {
assert.equal(shouldRetryRuntimeHostConflict('c'), false);
assert.equal(shouldRetryRuntimeHostConflict('cancel'), false);
assert.equal(shouldRetryRuntimeHostConflict('unexpected'), false);
assert.equal(resolveRuntimeHostCliConflictDecision('r', true), 'restart');
assert.equal(resolveRuntimeHostCliConflictDecision(' restart ', true), 'restart');
assert.equal(resolveRuntimeHostCliConflictDecision('r', false), 'cancel');
assert.equal(resolveRuntimeHostCliConflictDecision('w', true), 'wait');
assert.equal(resolveRuntimeHostCliConflictDecision('', true), 'cancel');
});

test('CLI reports an actionable stored-data startup failure', async () => {
Expand Down Expand Up @@ -476,12 +508,7 @@ test('remote profiles preserve shared compatibility errors', async () => {
}
});

function hostRegistration(
overrides: Partial<{
compatibilityEpoch: number;
lifecycleMode: 'ephemeral' | 'service';
}> = {},
) {
function hostRegistration(overrides: Partial<HostRegistration> = {}): HostRegistration {
return {
kind: 'maka-runtime-host' as const,
schemaVersion: RUNTIME_HOST_REGISTRATION_SCHEMA_VERSION,
Expand Down
Loading