fix(storybook): fill the app shell viewport - #3510
Merged
Merged
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the AppShell Storybook fixture so the shell frame can use the same 100dvh sizing rules as production, allowing the story to fill the Storybook iframe viewport (eliminating the bottom “white band” caused by the previous inline sizing override).
Changes:
- Removed the inline
height: '100%'on the AppShell story frame so.appFrame/.agents-layout-rootCSS (height: 100dvh) can take effect. - Kept the existing
minHeight: 640guardrail while allowing the frame to grow to the full viewport height.
Required Conclusion (per code-review skill):
- Is the current solution optimal for the actual problem? Yes. The root cause is the inline
height: '100%'overriding the CSSheight: 100dvhon.appFrame/.agents-layout-root, and removing it is the smallest coherent fix at the source of truth (the CSS rules). - If applicable, what production code can be deleted? none identified.
- If applicable, what low-quality tests can be deleted or replaced? none identified.
- Is a deeper refactor required, and what should the final structure be? No deeper refactor required; the story should rely on the same CSS sizing contracts as production rather than re-declaring height inline.
- Is the reviewed revision ready to merge? Yes.
- What residual risks or verification gaps remain? Minimal risk; change is isolated to Storybook presentation. No protected-area (security/licensing/release/governance) impact identified in this diff.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jackwener
approved these changes
Aug 22, 2026
jackwener
left a comment
Member
There was a problem hiding this comment.
Story layout is fullscreen; inner shell already uses height="fill". height: 100% on the frame is a percentage of an indefinite parent, so the story does not fill the canvas. Leaving minHeight: 640 is the right floor. Approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
100dvhapp-frame ruleVerification
npm --workspace @maka/desktop run typecheck:stories