Skip to content

fix(eval): make install preflight path test portable on macOS #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 2 commits into from
Aug 20, 2026
Merged

fix(eval): make install preflight path test portable on macOS #3283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
263c917
Use realpath for eval network policy preflight test
localhost-copilot Aug 20, 2026
e897fdf
Canonicalize eval network policy path in preflight test
localhost-copilot Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions packages/eval/src/__tests__/install-preflight.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import assert from 'node:assert/strict';
import { chmod, mkdtemp, mkdir, rm, symlink, writeFile } from 'node:fs/promises';
import { chmod, mkdtemp, mkdir, realpath, rm, symlink, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { test } from 'node:test';
Expand All @@ -13,11 +13,13 @@ test('preflights the pinned Python framework and Docker before execution', async
t.after(() => rm(root, { recursive: true, force: true }));
const trials = join(root, 'trials');
const mount = join(root, 'mount');
const egressTarget = join(root, 'egress-target');
const egress = join(root, 'egress');
await Promise.all([mkdir(trials), mkdir(mount), mkdir(egress)]);
await Promise.all([mkdir(trials), mkdir(mount), mkdir(egressTarget)]);
await symlink(egressTarget, egress, process.platform === 'win32' ? 'junction' : 'dir');
await Promise.all([
writeFile(join(egress, 'compose.yaml'), 'services: {}\n'),
writeFile(join(egress, 'network-policy.json'), '{}\n'),
writeFile(join(egressTarget, 'compose.yaml'), 'services: {}\n'),
writeFile(join(egressTarget, 'network-policy.json'), '{}\n'),
]);
const restore = setMachinePaths({
MAKA_TEST_PREFLIGHT_PYTHON: process.execPath,
Expand Down Expand Up @@ -46,10 +48,10 @@ test('preflights the pinned Python framework and Docker before execution', async
assert.equal(calls[0]?.environment.MAKA_TEST_PREFLIGHT_SECRET, undefined);
assert.equal(calls[0]?.environment.MAKA_EVAL_EGRESS_REQUIRED, '1');
assert.equal(calls[0]?.environment.MAKA_EVAL_EGRESS_ALLOWED_HOST, 'api.example.test');
assert.equal(
calls[0]?.environment.MAKA_EVAL_NETWORK_POLICY_PATH,
join(egress, 'network-policy.json'),
);
const networkPolicyPath = join(egress, 'network-policy.json');
const canonicalNetworkPolicyPath = await realpath(networkPolicyPath);
assert.notEqual(canonicalNetworkPolicyPath, networkPolicyPath);
assert.equal(calls[0]?.environment.MAKA_EVAL_NETWORK_POLICY_PATH, canonicalNetworkPolicyPath);
assert.deepEqual(calls[1], {
command: 'docker',
args: ['version', '--format', '{{.Server.Version}}'],
Expand Down