feat(desktop): localize Plan Mode - #2688
Merged
Merged
Conversation
xxhZs
approved these changes
Aug 12, 2026
xxhZs
left a comment
xxhZs
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the typed zh/en catalog, useUiLocale wiring for proposal/execution chrome and the abandon confirmation, and the surrounding Plan action paths. Model-authored proposal content and the Plan Runtime/IPC contracts remain untouched. The head merges cleanly with current main; CI is green, git diff --check passes, and Biome reports no issues in the changed files. No blocking findings.
2 tasks
1625567290
added a commit
to 1625567290/maka-agent
that referenced
this pull request
Aug 16, 2026
apache#2688 imported Plan Mode locale types from the removed @maka/core root barrel. Other locale catalogs already use @maka/core/ui-locale and @maka/core/plan. The root import breaks desktop main typecheck and cascades through every PR that merges with main. Generated-by: Grok
1625567290
added a commit
to 1625567290/maka-agent
that referenced
this pull request
Aug 16, 2026
apache#2688 imported Plan Mode locale types from the removed @maka/core root barrel. Other locale catalogs already use @maka/core/ui-locale and @maka/core/plan. The root import breaks desktop main typecheck and cascades through every PR that merges with main. Generated-by: Grok
This was referenced Aug 16, 2026
Astro-Han
pushed a commit
that referenced
this pull request
Aug 16, 2026
#2688 imported Plan Mode locale types from the removed @maka/core root barrel. Other locale catalogs already use @maka/core/ui-locale and @maka/core/plan. The root import breaks desktop main typecheck and cascades through every PR that merges with main. Generated-by: Grok
Astro-Han
pushed a commit
that referenced
this pull request
Aug 16, 2026
…3118) * fix(runtime): keep newly released Grok models on xAI OAuth discovery xai-oauth model fetch used filter: fallback-models, so ids absent from the bundled snapshot were dropped. Trust the server listing like xai API-key connections. fallbackModels remain the bootstrap fallback. Fixes #3116 Generated-by: Grok * test(runtime): drop the snapshot-pinned xai-oauth discovery case After removing the fallback-models filter, xai-oauth uses the same unfiltered protocol discovery path already covered by the provider contract matrix. Do not pin grok-4.6 as a snapshot fact. Generated-by: Grok * fix(desktop): import Plan Mode copy types from core subpaths #2688 imported Plan Mode locale types from the removed @maka/core root barrel. Other locale catalogs already use @maka/core/ui-locale and @maka/core/plan. The root import breaks desktop main typecheck and cascades through every PR that merges with main. Generated-by: Grok
Astro-Han
pushed a commit
that referenced
this pull request
Aug 16, 2026
) * refactor(storage): remove the leftover llm-connections.json store Delete FileConnectionStore, its relay-profile helper, and the package export. Desktop e2e and the Computer Use real-model script now seed connection-catalog.json through the Runtime Policy writer. Existing user llm-connections.json files stay inert on disk. Fixes #3107 Generated-by: Grok * docs: say leftover llm-connections.json files are not imported Throw if the fixture cannot resolve the zai-live connection id, and drop the unused extra root resolve in the catalog test. Generated-by: Grok * 修复连接目录测试数据迁移 * fix(desktop): import Plan Mode copy types from core subpaths #2688 imported Plan Mode locale types from the removed @maka/core root barrel. Other locale catalogs already use @maka/core/ui-locale and @maka/core/plan. The root import breaks desktop main typecheck and cascades through every PR that merges with main. Generated-by: Grok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2687
Part of #2672
Tests
中文对照
摘要
测试