Conversation
c4fa57b to
b6a9d2f
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
This branch is
That is not "both sides added something", it is "one side deleted it and the other is still using it." Taking this branch's version would silently revert an intentional refactor on I ran The same applies to the stack above it: #2622 (20 commits) and #2623 (30 commits) build on this one, and the first commit here already hits this. Rebasing #2621 first should shrink the other two considerably. Happy to take another pass at whatever is purely mechanical once the export question is settled — just say so on this thread. |
59f8384 to
9f1418b
Compare
|
Rebased this Draft on the rebuilt producer-boundary branch and current main. The release conflict was resolved in favor of the post-bundled-Git contract: this branch adds only the attested bundled npm runtime and does not restore Dugite, Git payloads, Git notices, or Git source-offer assets. Legacy installer verification keeps its explicit historical resource contract. The focused npm/runtime and packaged-resource suites pass (29 passed, 2 platform skips). 中文说明该 Draft 已基于重建后的 producer boundary 与最新主线更新。发布冲突按移除 bundled Git 后的合同处理:只保留经过 attestation 的 bundled npm runtime,不恢复 Dugite、Git payload、Git notices 或 Git source-offer;旧安装包验证继续使用明确的历史资源合同。相关定向测试为 29 通过、2 个平台条件跳过。 |
|
Closing this Draft as superseded. The npm runtime attestation work has been rebuilt from the newer baseline and continues in the replacement stack. The design discussion and review history here remain useful, but this branch will not be merged or developed further. Replacement: 中文说明关闭此 Draft,标记为已被新实现替代。 npm runtime attestation 已从更新的基线重新构建,并在替代 PR 中继续推进。本 PR 的设计讨论和审查记录仍会保留,但该分支不会继续开发或合并。 替代实现: |
Summary
Attests the packaged npm runtime before it can issue the process-local capability consumed by managed provisioning. The attestation binds platform, architecture, Node/npm versions, declared runtime files, and the fixed execution policy; every managed invocation revalidates the declared runtime tree.
Trust boundary
The manifest proves runtime integrity inside an already authorized release resource root; it is not a standalone provenance trust root. Provenance comes from the outer signed application and release/update chain. If an attacker can replace both the packaged npm tree and its manifest, this layer alone cannot distinguish that tree from a Maka release.
Primary invariant
No path, version string, or caller-constructed object can self-authorize npm provisioning. Only a process-local capability issued after bundled-runtime attestation can cross the producer boundary.
Verification
bindeclaration.Stack
中文说明
本切片在 managed provisioning 前验证随包发布的 npm runtime,并签发进程内不可伪造的 capability。验证绑定平台、架构、Node/npm 版本、完整文件清单与固定执行策略;每次调用都会重新验证 runtime tree。
这里明确区分两层信任:外层应用签名与发布/更新链提供来源信任,manifest 只证明已授权资源目录内的运行时完整性。manifest 本身不是独立的密码学信任根。