fix(release): align filesystem worker smoke protocol - #2609
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the
Verify the final DMGfailure in release run #31318321465, where the verifier sent protocol v4 after #2532 upgraded the worker to v5.After merge, rerun the
Release desktopworkflow frommainfor v0.1.9.Verification
node --test scripts/macos-arm64-release.test.mjs(3/3 passed)git diff --checkA clean
npm ci --ignore-scriptswas attempted but the registry connection reset while fetching dependencies. The focused test was run against the built protocol module after TypeScript emitted it.