fix(dev): build runtime-host in the desktop library graph - #2570
Merged
Merged
Conversation
npm run dev only tsc --build tsconfig.lib.json. After the Runtime Host cutover, desktop main imports @maka/runtime-host/protocol at runtime, but that package was missing from the lib graph — stale dist then crashed Electron with missing named exports such as decodeExternalSessionCatalogQueryInput.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run devonly runstsc --build tsconfig.lib.json. After the Runtime Host cutover, desktop main imports@maka/runtime-host/protocolat runtime (esbuild leaves packages external), but that package was missing from the lib graph.Stale/missing
packages/runtime-host/distthen crashes Electron on load with errors such as:Add
packages/runtime-hosttotsconfig.lib.jsonso dev always rebuilds it.Verification
npm run devreaches[startup] app readyafter the changeimport { decodeExternalSessionCatalogQueryInput } from '@maka/runtime-host/protocol'